Page MenuHomePhabricator

Use unique_ptr
ClosedPublic

Authored by jgalenson on Aug 24 2018, 12:08 PM.

Details

Reviewers
pcc
vitalybuka
Summary

Is this the best way to create the MCInstrAnalysis? Is there some way of reusing an existing one?

Diff Detail

Event Timeline

jgalenson created this revision.Aug 24 2018, 12:08 PM
pcc accepted this revision.Aug 24 2018, 12:37 PM

LGTM

I think this is the way that you are supposed to do it. It's the way that we're doing it elsewhere.
http://llvm-cs.pcc.me.uk/?q=createMCInstrAnalysis

This revision is now accepted and ready to land.Aug 24 2018, 12:37 PM
In D51230#1212854, @pcc wrote:

LGTM

I think this is the way that you are supposed to do it. It's the way that we're doing it elsewhere.
http://llvm-cs.pcc.me.uk/?q=createMCInstrAnalysis

Yeah, that's why I added this. I was just wondering if there was some better way.

Thanks. I'll commit it now.

vitalybuka accepted this revision.Aug 24 2018, 12:40 PM