This is an archive of the discontinued LLVM Phabricator instance.

Differential D51158

[PDB] Make variables.test to pass using a 32-bit compiler too
ClosedPublic

Authored by aleksandr.urakov on Aug 23 2018, 6:07 AM.

Details

Reviewers
stella.stamenova
asmith
Commits
rG562811a86d7e: [PDB] Make variables.test to pass using a 32-bit compiler too
rLLDB340597: [PDB] Make variables.test to pass using a 32-bit compiler too
rL340597: [PDB] Make variables.test to pass using a 32-bit compiler too
Summary

variables.test depends on mangled names, but the mangling depends on the bitness. This patch specifies the bitness explicitly, so mangled names doesn't differ when a 32-bit version of the compiler is used.

Diff Detail

Repository
rL LLVM

Event Timeline

aleksandr.urakov created this revision.Aug 23 2018, 6:07 AM
stella.stamenova accepted this revision.Aug 23 2018, 9:40 AM

Thanks!

This revision is now accepted and ready to land.Aug 23 2018, 9:40 AM
Closed by commit rL340597: [PDB] Make variables.test to pass using a 32-bit compiler too (authored by aleksandr.urakov). · Explain WhyAug 24 2018, 12:25 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 24 2018, 12:25 AM

Revision Contents

PathSize
lldb/
trunk/
lit/
SymbolFile/
PDB/
2 lines

Diff 162327

lldb/trunk/lit/SymbolFile/PDB/variables.test

REQUIRES: windows REQUIRES: windows
RUN: clang-cl /Z7 /c /GS- %S/Inputs/VariablesTest.cpp /o %T/VariablesTest.cpp.obj RUN: clang-cl -m64 /Z7 /c /GS- %S/Inputs/VariablesTest.cpp /o %T/VariablesTest.cpp.obj
RUN: link %T/VariablesTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main /OUT:%T/VariablesTest.cpp.exe RUN: link %T/VariablesTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main /OUT:%T/VariablesTest.cpp.exe
RUN: lldb-test symbols %T/VariablesTest.cpp.exe | FileCheck %s RUN: lldb-test symbols %T/VariablesTest.cpp.exe | FileCheck %s
CHECK: Module [[MOD:.*]] CHECK: Module [[MOD:.*]]
CHECK: SymbolVendor ([[MOD]]) CHECK: SymbolVendor ([[MOD]])
CHECK: CompileUnit{{.*}}, language = "c++", file = '{{.*}}\VariablesTest.cpp' CHECK: CompileUnit{{.*}}, language = "c++", file = '{{.*}}\VariablesTest.cpp'
CHECK-DAG: Variable{{.*}}, name = "g_IntVar" CHECK-DAG: Variable{{.*}}, name = "g_IntVar"
CHECK-SAME: scope = global, location = {{.*}}, external CHECK-SAME: scope = global, location = {{.*}}, external
Show All 40 Lines
CHECK-DAG: Variable{{.*}}, name = "a" CHECK-DAG: Variable{{.*}}, name = "a"
CHECK-SAME: scope = parameter CHECK-SAME: scope = parameter
CHECK-DAG: Function{[[FID4:.*]]}, mangled = ?Func@Class@@QEAAXXZ CHECK-DAG: Function{[[FID4:.*]]}, mangled = ?Func@Class@@QEAAXXZ
CHECK-NEXT: Block{[[FID4]]} CHECK-NEXT: Block{[[FID4]]}
CHECK-DAG: Variable{{.*}}, name = "this" CHECK-DAG: Variable{{.*}}, name = "this"
CHECK-SAME: scope = parameter CHECK-SAME: scope = parameter
CHECK-SAME: artificial CHECK-SAME: artificial
No newline at end of file No newline at end of file