This is an archive of the discontinued LLVM Phabricator instance.

Differential D50973

AMDGPU: fix existing alias rules for constant and global
ClosedPublic

Authored by hakzsam on Aug 20 2018, 8:03 AM.

Download Raw Diff

Details

Reviewers

arsenm

Summary

Constant and global may alias, also one rules table wasn't
ordered correctly.

Pinpointed by Matt.

Diff Detail

Event Timeline

hakzsam created this revision.Aug 20 2018, 8:03 AM

Herald added subscribers: t-tye, tpr, dstuttard and 6 others. · View Herald TranscriptAug 20 2018, 8:03 AM

arsenm added inline comments.Aug 20 2018, 8:42 AM

test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll
18–20	With a function with swapped parameters, is the other dimension of the table stressed?

hakzsam added inline comments.Aug 20 2018, 12:15 PM

test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll
18–20	Yes. I will update.

v2: add a test with swapped parameters

LGTM

This revision is now accepted and ready to land.Aug 20 2018, 12:30 PM

r340416

arsenm closed this revision.Feb 22 2019, 7:00 AM

Revision Contents

Path

Size

lib/

Target/

AMDGPU/

AMDGPUAliasAnalysis.cpp

10 lines

test/

CodeGen/

AMDGPU/

amdgpu-alias-analysis.ll

12 lines

Diff 161532

lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp

Context not available.
	static const AliasResult ASAliasRulesPrivIsZero[6][6] = {	static const AliasResult ASAliasRulesPrivIsZero[6][6] = {
	/* Private Global Constant Group Flat Region*/	/* Private Global Constant Group Flat Region*/
	/* Private */ {MayAlias, NoAlias , NoAlias , NoAlias , MayAlias, NoAlias},	/* Private */ {MayAlias, NoAlias , NoAlias , NoAlias , MayAlias, NoAlias},
	/* Global */ {NoAlias , MayAlias, NoAlias , NoAlias , MayAlias, NoAlias},	/* Global */ {NoAlias , MayAlias, MayAlias, NoAlias , MayAlias, NoAlias},
	/* Constant */ {NoAlias , NoAlias , MayAlias, NoAlias , MayAlias, NoAlias},	/* Constant */ {NoAlias , MayAlias, MayAlias, NoAlias , MayAlias, NoAlias},
	/* Group */ {NoAlias , NoAlias , NoAlias , MayAlias, MayAlias, NoAlias},	/* Group */ {NoAlias , NoAlias , NoAlias , MayAlias, MayAlias, NoAlias},
	/* Flat */ {MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias},	/* Flat */ {MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias},
	/* Region */ {NoAlias , NoAlias , NoAlias , NoAlias , MayAlias, MayAlias}	/* Region */ {NoAlias , NoAlias , NoAlias , NoAlias , MayAlias, MayAlias}
Context not available.
	static const AliasResult ASAliasRulesGenIsZero[6][6] = {	static const AliasResult ASAliasRulesGenIsZero[6][6] = {
	/* Flat Global Region Group Constant Private */	/* Flat Global Region Group Constant Private */
	/* Flat */ {MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias},	/* Flat */ {MayAlias, MayAlias, MayAlias, MayAlias, MayAlias, MayAlias},
	/* Global */ {MayAlias, MayAlias, NoAlias , NoAlias , NoAlias , NoAlias},	/* Global */ {MayAlias, MayAlias, NoAlias , NoAlias , MayAlias, NoAlias},
	/* Constant */ {MayAlias, NoAlias , MayAlias, NoAlias , NoAlias, NoAlias},
	/* Group */ {MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , NoAlias},
	/* Region */ {MayAlias, NoAlias , NoAlias , NoAlias, MayAlias, NoAlias},	/* Region */ {MayAlias, NoAlias , NoAlias , NoAlias, MayAlias, NoAlias},
		/* Group */ {MayAlias, NoAlias , NoAlias , MayAlias, NoAlias , NoAlias},
		/* Constant */ {MayAlias, MayAlias, MayAlias, NoAlias , NoAlias, NoAlias},
	/* Private */ {MayAlias, NoAlias , NoAlias , NoAlias , NoAlias , MayAlias}	/* Private */ {MayAlias, NoAlias , NoAlias , NoAlias , NoAlias , MayAlias}
	};	};
	static_assert(AMDGPUAS::MAX_COMMON_ADDRESS <= 6, "Addr space out of range");	static_assert(AMDGPUAS::MAX_COMMON_ADDRESS <= 6, "Addr space out of range");
Context not available.

test/CodeGen/AMDGPU/amdgpu-alias-analysis.ll

Context not available.
	ret void	ret void
	}	}

		; CHECK: MayAlias: i8 addrspace(1)* %p1, i8 addrspace(4)* %p

		define void @test_constant_vs_global(i8 addrspace(4)* %p, i8 addrspace(1)* %p1) {
		ret void
		}
		arsenmUnsubmitted Not Done Reply Inline Actions With a function with swapped parameters, is the other dimension of the table stressed? arsenm: With a function with swapped parameters, is the other dimension of the table stressed?
		hakzsamAuthorUnsubmitted Not Done Reply Inline Actions Yes. I will update. hakzsam: Yes. I will update.

		; CHECK: MayAlias: i8 addrspace(1)* %p, i8 addrspace(4)* %p1

		define void @test_global_vs_constant(i8 addrspace(1)* %p, i8 addrspace(4)* %p1) {
		ret void
		}

Context not available.