Page Menu
Home
Phabricator
This is an archive of the discontinued LLVM Phabricator instance.
Paths
Table of Contents
t
-
cfe/trunk/lib/Frontend/
-
trunk/
-
lib/
-
Frontend/
-
PrecompiledPreamble.cpp
Hide Panel
f
Keyboard Reference
?
Differential
D50967
[Preamble] Fix an undefined behavior when checking an empty preamble can be reused.
Closed
Public
Authored by
hokein
on Aug 20 2018, 5:28 AM.
Download Raw Diff
Details
Reviewers
ilya-biryukov
Commits
rGa3b34574cce8: [Preamble] Fix an undefined behavior when checking an empty preamble can be…
rC340403: [Preamble] Fix an undefined behavior when checking an empty preamble can be…
rL340403: [Preamble] Fix an undefined behavior when checking an empty preamble can be…
Summary
Passing nullptr to memcmp is UB.
Diff Detail
Repository
rL LLVM
Event Timeline
hokein
created this revision.
Aug 20 2018, 5:28 AM
Harbormaster
completed remote builds in
B21671: Diff 161464
.
Aug 20 2018, 5:28 AM
hokein
updated this revision to
Diff 161891
.
Aug 22 2018, 12:51 AM
Comment Actions
Use the std::equal to replace the memcmp.
ilya-biryukov
accepted this revision.
Aug 22 2018, 2:29 AM
Comment Actions
LGTM. Thanks!
This revision is now accepted and ready to land.
Aug 22 2018, 2:29 AM
Closed by commit
rL340403: [Preamble] Fix an undefined behavior when checking an empty preamble can be…
(authored by
hokein
).
·
Explain Why
Aug 22 2018, 5:34 AM
This revision was automatically updated to reflect the committed changes.
Herald
added a subscriber:
llvm-commits
.
·
View Herald Transcript
Aug 22 2018, 5:34 AM