Currently, it is possible to use yaml2obj for producing SHT_GROUP sections
of type GRP_COMDAT. For LLD test case I need to produce an object with
a broken (different from GRP_COMDAT) type.
The patch teaches tool to do such things.
Differential D50761
[yaml2obj] - Teach tool to produce SHT_GROUP section with a custom type. grimar on Aug 15 2018, 3:46 AM. Authored by
Details Currently, it is possible to use yaml2obj for producing SHT_GROUP sections The patch teaches tool to do such things.
Diff Detail Event TimelineComment Actions Is it normal for yaml2obj to only parse hex values and not decimal for other fields?
Comment Actions
I think usually it allows any numeric values, but I think it is reasonable for this place to allow only hex values.
(http://www.sco.com/developers/gabi/2001-04-24/ch4.sheader.html#section_group_flags) So I see why we might want to use section name, the name of the constant and (now) hex value of constant,
Comment Actions After one more look, since the field name is SectionOrType, I think it is ok to accept decimals here too for specifying a section index. Comment Actions LGTM, with nit. I guess if somebody wants decimal support later, they can add it then.
Comment Actions LGTM.
|
Maybe you should make this a decimal?