This is an archive of the discontinued LLVM Phabricator instance.

Differential D5075

Add missing override on ARMAsmBackend's dtor.
ClosedPublic

Authored by jfb on Aug 26 2014, 2:07 PM.

Details

Reviewers
dschuff
Commits
rG12cc99eb13d1: Add missing override on ARMAsmBackend's dtor.
rL216912: Add missing override on ARMAsmBackend's dtor.

Diff Detail

Event Timeline

jfb updated this revision to Diff 12966.Aug 26 2014, 2:07 PM
jfb retitled this revision from to Add missing override on ARMAsmBackend's dtor..
jfb edited the test plan for this revision. (Show Details)
Herald added a subscriber: aemerson. · View Herald TranscriptAug 26 2014, 2:07 PM
jfb added a subscriber: Unknown Object (MLST).Aug 26 2014, 2:08 PM
dschuff accepted this revision.Aug 27 2014, 9:34 AM
dschuff added a reviewer: dschuff.
This revision is now accepted and ready to land.Aug 27 2014, 9:34 AM
jfb closed this revision.Sep 2 2014, 9:36 AM
jfb updated this revision to Diff 13166.

Closed by commit rL216912 (authored by @jfb).

Revision Contents

PathSize
lib/
Target/
ARM/
MCTargetDesc/
3 lines

Diff 12966

lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Linesclass ARMAsmBackend : public MCAsmBackend {
const MCSubtargetInfo* STI; const MCSubtargetInfo* STI;
bool isThumbMode; // Currently emitting Thumb code. bool isThumbMode; // Currently emitting Thumb code.
bool IsLittleEndian; // Big or little endian. bool IsLittleEndian; // Big or little endian.
public: public:
ARMAsmBackend(const Target &T, const StringRef TT, bool IsLittle) ARMAsmBackend(const Target &T, const StringRef TT, bool IsLittle)
: MCAsmBackend(), STI(ARM_MC::createARMMCSubtargetInfo(TT, "", "")), : MCAsmBackend(), STI(ARM_MC::createARMMCSubtargetInfo(TT, "", "")),
isThumbMode(TT.startswith("thumb")), IsLittleEndian(IsLittle) {} isThumbMode(TT.startswith("thumb")), IsLittleEndian(IsLittle) {}
~ARMAsmBackend() { ~ARMAsmBackend() override {
delete STI; delete STI;
} }
unsigned getNumFixupKinds() const override { unsigned getNumFixupKinds() const override {
return ARM::NumTargetFixupKinds; return ARM::NumTargetFixupKinds;
} }
bool hasNOP() const { bool hasNOP() const {
▲ Show 20 Lines • Show All 792 Lines • ▼ Show 20 LinesMCAsmBackend *llvm::createThumbLEAsmBackend(const Target &T,
return createARMAsmBackend(T, MRI, TT, CPU, true); return createARMAsmBackend(T, MRI, TT, CPU, true);
} }
MCAsmBackend *llvm::createThumbBEAsmBackend(const Target &T, MCAsmBackend *llvm::createThumbBEAsmBackend(const Target &T,
const MCRegisterInfo &MRI, const MCRegisterInfo &MRI,
StringRef TT, StringRef CPU) { StringRef TT, StringRef CPU) {
return createARMAsmBackend(T, MRI, TT, CPU, false); return createARMAsmBackend(T, MRI, TT, CPU, false);
} }