This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Split -gx strip flag into -g -x
ClosedPublic

Authored by phosek on Aug 13 2018, 6:58 PM.

Reviewers

jakehehrlich

Commits

Summary

llvm-strip doesn't handle -gx spelling, so we need to split these
as two separate flags.

This revision is now accepted and ready to land.Aug 13 2018, 6:59 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

cmake/

modules/

2 lines

Show First 20 Lines • Show All 1,560 Lines • ▼ Show 20 Lines	function(llvm_externalize_debuginfo name)

if(NOT LLVM_EXTERNALIZE_DEBUGINFO_SKIP_STRIP)		if(NOT LLVM_EXTERNALIZE_DEBUGINFO_SKIP_STRIP)
if(APPLE)		if(APPLE)
if(NOT CMAKE_STRIP)		if(NOT CMAKE_STRIP)
set(CMAKE_STRIP xcrun strip)		set(CMAKE_STRIP xcrun strip)
endif()		endif()
set(strip_command COMMAND ${CMAKE_STRIP} -Sxl $<TARGET_FILE:${name}>)		set(strip_command COMMAND ${CMAKE_STRIP} -Sxl $<TARGET_FILE:${name}>)
else()		else()
set(strip_command COMMAND ${CMAKE_STRIP} -gx $<TARGET_FILE:${name}>)		set(strip_command COMMAND ${CMAKE_STRIP} -g -x $<TARGET_FILE:${name}>)
endif()		endif()
endif()		endif()

if(APPLE)		if(APPLE)
if(CMAKE_CXX_FLAGS MATCHES "-flto"		if(CMAKE_CXX_FLAGS MATCHES "-flto"
OR CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-flto")		OR CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE} MATCHES "-flto")

set(lto_object ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${name}-lto.o)		set(lto_object ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${name}-lto.o)
▲ Show 20 Lines • Show All 128 Lines • Show Last 20 Lines