This is an archive of the discontinued LLVM Phabricator instance.

[RuntimeDyld] Fix a calculation of common symbols size
ClosedPublic

Authored by sidorovd on Aug 3 2018, 3:57 AM.

Reviewers

Commits

Summary

To prevent unnecessary 'Unable to allocate memory for common symbols'.

Ping

Looks good to me. Thanks Dimitri!

Do you have commit access? If not, I would be happy to commit on your behalf.

This revision is now accepted and ready to land.Aug 16 2018, 11:38 AM

No, I don't have, commit it please.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

ExecutionEngine/

RuntimeDyld/

2 lines

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines	if (JITSymFlags->isWeak() \|\| JITSymFlags->isCommon()) {
if (JITSymFlags->isWeak())		if (JITSymFlags->isWeak())
*JITSymFlags &= ~JITSymbolFlags::Weak;		*JITSymFlags &= ~JITSymbolFlags::Weak;
if (JITSymFlags->isCommon()) {		if (JITSymFlags->isCommon()) {
*JITSymFlags &= ~JITSymbolFlags::Common;		*JITSymFlags &= ~JITSymbolFlags::Common;
uint32_t Align = I->getAlignment();		uint32_t Align = I->getAlignment();
uint64_t Size = I->getCommonSize();		uint64_t Size = I->getCommonSize();
if (!CommonAlign)		if (!CommonAlign)
CommonAlign = Align;		CommonAlign = Align;
CommonSize += alignTo(CommonSize, Align) + Size;		CommonSize = alignTo(CommonSize, Align) + Size;
CommonSymbolsToAllocate.push_back(*I);		CommonSymbolsToAllocate.push_back(*I);
}		}
} else		} else
continue;		continue;
}		}

if (Flags & SymbolRef::SF_Absolute &&		if (Flags & SymbolRef::SF_Absolute &&
SymType != object::SymbolRef::ST_File) {		SymType != object::SymbolRef::ST_File) {
▲ Show 20 Lines • Show All 963 Lines • Show Last 20 Lines