Fix: ClangHighlighter.cpp should not be in CopyFiles, but in lldb-core targets

[sgraenitz]

Summary

Fix linker error:
Undefined symbols for architecture x86_64:

"lldb_private::ClangHighlighter::ClangHighlighter()", referenced from:
    lldb_private::ObjCLanguage::ObjCLanguage() in liblldb-core.a(ObjCLanguage.o)
    lldb_private::CPlusPlusLanguage::CPlusPlusLanguage() in liblldb-core.a(CPlusPlusLanguage.o)
    lldb_private::ObjCPlusPlusLanguage::ObjCPlusPlusLanguage() in liblldb-core.a(ObjCPlusPlusLanguage.o)
"vtable for lldb_private::ClangHighlighter", referenced from:
    lldb_private::ClangHighlighter::~ClangHighlighter() in liblldb-core.a(ObjCLanguage.o)
    lldb_private::ClangHighlighter::~ClangHighlighter() in liblldb-core.a(CPlusPlusLanguage.o)
    lldb_private::ClangHighlighter::~ClangHighlighter() in liblldb-core.a(ObjCPlusPlusLanguage.o)

[teemperor]

This was changed by rLLDB338712 so I think Tim probably knows better what's going on here.

[davide]

My understanding is that @t.p.northover just committed the same patch.

[sgraenitz]

Yep

lldb.xcodeproj/project.pbxproj

942829BE1A89835300521B30 /* CopyFiles */ = {
       runOnlyForDeploymentPostprocessing = 1;
     };
     AF90106415AB7D2900FF120D /* CopyFiles */ = {
       isa = PBXCopyFilesBuildPhase;
       buildActionMask = 8;
       dstPath = "$(DEVELOPER_INSTALL_DIR)/usr/share/man/man1";
       dstSubfolderSpec = 0;
       files = (
-        58A080AE2112AAC500D5580F /* ClangHighlighter.h in CopyFiles */,
-        58A080AC2112AABB00D5580F /* ClangHighlighter.cpp in CopyFiles */,
         AF90106515AB7D3600FF120D /* lldb.1 in CopyFiles */,
       );
       runOnlyForDeploymentPostprocessing = 1;
     };
     AFA9B71820606A13008E86C6 /* CopyFiles */ = {
       isa = PBXCopyFilesBuildPhase;
       buildActionMask = 8;
       dstPath = /AppleInternal/Library/LaunchDaemons;
2689FFC613353D7A00698AC0 /* Sources */ = {
         268900EB13353E6F00698AC0 /* ExecutionContext.cpp in Sources */,
         268900EC13353E6F00698AC0 /* LanguageRuntime.cpp in Sources */,
         268900ED13353E6F00698AC0 /* ObjCLanguageRuntime.cpp in Sources */,
         4CC7C6581D529B950076FF94 /* DWARFASTParserOCaml.cpp in Sources */,
         268900EE13353E6F00698AC0 /* PathMappingList.cpp in Sources */,
         4C2479BD1BA39295009C9A7B /* FunctionCaller.cpp in Sources */,
         AF2907BF1D3F082400E10654 /* DynamicLoaderMacOS.cpp in Sources */,
         268900EF13353E6F00698AC0 /* Platform.cpp in Sources */,
+        4FA04FFA211362230011EDE5 /* ClangHighlighter.cpp in Sources */,
         268900F013353E6F00698AC0 /* Process.cpp in Sources */,
         26BC17AD18C7F4CB00D2196D /* RegisterContextPOSIXCore_mips64.cpp in Sources */,
         268900F113353E6F00698AC0 /* RegisterContext.cpp in Sources */,
         6D55BAED1A8CD0A800A70529 /* PlatformAndroid.cpp in Sources */,
         268900F213353E6F00698AC0 /* SectionLoadList.cpp in Sources */,
         268900F313353E6F00698AC0 /* StackFrame.cpp in Sources */,
         268900F413353E6F00698AC0 /* StackFrameList.cpp in Sources */,
         268900F513353E6F00698AC0 /* StackID.cpp in Sources */,