Page MenuHomePhabricator

XFAILS for http://reviews.llvm.org/D3969
AbandonedPublic

Authored by jroelofs on Aug 21 2014, 3:02 PM.

Details

Reviewers
mclow.lists

Diff Detail

Event Timeline

jroelofs updated this revision to Diff 12808.Aug 21 2014, 3:02 PM
jroelofs retitled this revision from to XFAILS for http://reviews.llvm.org/D3969.
jroelofs updated this object.
jroelofs edited the test plan for this revision. (Show Details)
jroelofs added a reviewer: mclow.lists.
EricWF added a subscriber: EricWF.Aug 21 2014, 4:04 PM

Should these be XFAIL or UNSUPPORTED? I favor UNSUPPORTED.

Actually, UNSUPPORTED would be nice for the bulk of them... that would save a lot of time attempting to compile things that we know are going to fail.

I think at least one for each header where I've added the error message should be XFAIL, that way the error message path gets tested a bit.