This is an archive of the discontinued LLVM Phabricator instance.

Differential D50112

[Android] Increase default new alignment for Android
ClosedPublic

Authored by pirama on Jul 31 2018, 3:16 PM.

Details

Reviewers
rsmith
nickdesaulniers
Commits
rGb818347aa08d: [Android] Increase default new alignment for Android
rL338603: [Android] Increase default new alignment for Android
rC338603: [Android] Increase default new alignment for Android
Summary

Android's memory allocators also guarantee 8-byte alignment for 32-bit
architectures and 16-byte alignment for 64-bit.

Diff Detail

Repository
rC Clang

Event Timeline

pirama created this revision.Jul 31 2018, 3:16 PM
Harbormaster completed remote builds in B20929: Diff 158402.Jul 31 2018, 3:17 PM
nickdesaulniers accepted this revision.Jul 31 2018, 3:37 PM
This revision is now accepted and ready to land.Jul 31 2018, 3:37 PM
rsmith accepted this revision.Aug 1 2018, 10:32 AM
Closed by commit rC338603: [Android] Increase default new alignment for Android (authored by pirama). · Explain WhyAug 1 2018, 10:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Basic/
5 lines
test/
Preprocessor/
2 lines

Diff 158574

lib/Basic/TargetInfo.cpp

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 LinesTargetInfo::TargetInfo(const llvm::Triple &T) : TargetOpts(), Triple(T) {
AccumScale = 15; AccumScale = 15;
LongAccumScale = 31; LongAccumScale = 31;
SuitableAlign = 64; SuitableAlign = 64;
DefaultAlignForAttributeAligned = 128; DefaultAlignForAttributeAligned = 128;
MinGlobalAlign = 0; MinGlobalAlign = 0;
// From the glibc documentation, on GNU systems, malloc guarantees 16-byte // From the glibc documentation, on GNU systems, malloc guarantees 16-byte
// alignment on 64-bit systems and 8-byte alignment on 32-bit systems. See // alignment on 64-bit systems and 8-byte alignment on 32-bit systems. See
// https://www.gnu.org/software/libc/manual/html_node/Malloc-Examples.html // https://www.gnu.org/software/libc/manual/html_node/Malloc-Examples.html.
if (T.isGNUEnvironment() || T.isWindowsMSVCEnvironment()) // This alignment guarantee also applies to Windows and Android.
if (T.isGNUEnvironment() || T.isWindowsMSVCEnvironment() || T.isAndroid())
NewAlign = Triple.isArch64Bit() ? 128 : Triple.isArch32Bit() ? 64 : 0; NewAlign = Triple.isArch64Bit() ? 128 : Triple.isArch32Bit() ? 64 : 0;
else else
NewAlign = 0; // Infer from basic type alignment. NewAlign = 0; // Infer from basic type alignment.
HalfWidth = 16; HalfWidth = 16;
HalfAlign = 16; HalfAlign = 16;
FloatWidth = 32; FloatWidth = 32;
FloatAlign = 32; FloatAlign = 32;
DoubleWidth = 64; DoubleWidth = 64;
▲ Show 20 Lines • Show All 720 Lines • Show Last 20 Lines

test/Preprocessor/init.c

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 9,013 Lines • ▼ Show 20 Lines
// NORTTI-NOT:#define __GXX_RTTI // NORTTI-NOT:#define __GXX_RTTI
// NORTTI:#define __STDC__ 1 // NORTTI:#define __STDC__ 1
// //
// RUN: %clang_cc1 -triple arm-linux-androideabi -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix ANDROID %s // RUN: %clang_cc1 -triple arm-linux-androideabi -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix ANDROID %s
// ANDROID-NOT:#define __ANDROID_API__ // ANDROID-NOT:#define __ANDROID_API__
// ANDROID:#define __ANDROID__ 1 // ANDROID:#define __ANDROID__ 1
// //
// RUN: %clang_cc1 -x c++ -triple i686-linux-android -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix I386-ANDROID-CXX %s // RUN: %clang_cc1 -x c++ -triple i686-linux-android -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix I386-ANDROID-CXX %s
// I386-ANDROID-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 4U // I386-ANDROID-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 8U
// //
// RUN: %clang_cc1 -x c++ -triple x86_64-linux-android -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix X86_64-ANDROID-CXX %s // RUN: %clang_cc1 -x c++ -triple x86_64-linux-android -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix X86_64-ANDROID-CXX %s
// X86_64-ANDROID-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 16UL // X86_64-ANDROID-CXX:#define __STDCPP_DEFAULT_NEW_ALIGNMENT__ 16UL
// //
// RUN: %clang_cc1 -triple arm-linux-androideabi20 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix ANDROID20 %s // RUN: %clang_cc1 -triple arm-linux-androideabi20 -E -dM < /dev/null | FileCheck -match-full-lines -check-prefix ANDROID20 %s
// ANDROID20:#define __ANDROID_API__ 20 // ANDROID20:#define __ANDROID_API__ 20
// ANDROID20:#define __ANDROID__ 1 // ANDROID20:#define __ANDROID__ 1
// //
▲ Show 20 Lines • Show All 1,402 Lines • Show Last 20 Lines