This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement BGEZALS and BLTZALS instructions
ClosedPublic

Authored by jkolek on Aug 21 2014, 5:49 AM.

Details

Summary

Implement microMIPS branch instructions BGEZALS and BLTZALS with short delay slot.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 12761.Aug 21 2014, 5:49 AM
jkolek retitled this revision from to [mips][microMIPS] Implement BGEZALS and BLTZALS instructions.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, vmedic.
jkolek added a subscriber: zoran.jovanovic.
dsanders accepted this revision.Sep 2 2014, 5:29 AM
dsanders edited edge metadata.

LGTM with a nit

lib/Target/Mips/MicroMipsInstrInfo.td
119

Nit: It's not very clear what the zero refers to in 'BranchZeroLinkMM'. Would 'BranchCompareToZeroLinkMM' be better?

This revision is now accepted and ready to land.Sep 2 2014, 5:29 AM
jkolek updated this revision to Diff 13625.Sep 12 2014, 6:14 AM
jkolek edited edge metadata.

The class 'BranchZeroLinkMM' has been renamed to 'BranchCompareToZeroLinkMM'.

Diffusion closed this revision.Sep 12 2014, 7:01 AM
Diffusion updated this revision to Diff 13631.

Closed by commit rL217678 (authored by zjovanovic).

jkolek added a subscriber: Unknown Object (MLST).Nov 18 2014, 5:55 AM