Page MenuHomePhabricator

docs: Emphasize ArrayRef over SmallVectorImpl
ClosedPublic

Authored by dexonsmith on Jul 26 2018, 3:29 PM.

Details

Summary

The section on SmallVector has a note about preferring SmallVectorImpl for APIs but doesn't mention ArrayRef. Although ArrayRef is discussed elsewhere, let's re-emphasize here.

Diff Detail

Event Timeline

dexonsmith created this revision.Jul 26 2018, 3:29 PM

Drive-by-review here.

llvm/docs/ProgrammersManual.rst
1550

s/basically just//

1577–1580

I suggest "discouraged" instead of "bad".

1588–1589

s/is so widely/is widely/
s/really isn't/is no longer/
s/"private to the implementation" anymore/an implementation detail/

bogner accepted this revision.Sep 25 2018, 11:12 AM

LGTM once dberris's suggestions are taken into account

This revision is now accepted and ready to land.Sep 25 2018, 11:12 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Oct 6, 3:16 PM
Herald added a subscriber: ributzka. · View Herald Transcript