Page MenuHomePhabricator

Don't print two errors for unknown commands.
ClosedPublic

Authored by teemperor on Jul 25 2018, 6:18 PM.

Details

Summary

We always print two error messages when we hit an unknown command. As the function
CommandInterpreter::HandleCommand that prints the second error message unconditionally called the CommandInterpreter::ResolveCommandImpl before (which prints the first error message), we can just remove
that second error message.

Fixes https://bugs.llvm.org/show_bug.cgi?id=38312

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jul 25 2018, 6:18 PM
labath accepted this revision.Jul 26 2018, 1:42 AM
labath added a subscriber: labath.

Looks good. It would be nice to mention the name of that other function in the commit message.

This revision is now accepted and ready to land.Jul 26 2018, 1:42 AM
teemperor edited the summary of this revision. (Show Details)Jul 26 2018, 9:31 AM
This revision was automatically updated to reflect the committed changes.