This is an archive of the discontinued LLVM Phabricator instance.

llvm-xray: Broken chrome trace event format output
ClosedPublic

Authored by chris3k on Jul 23 2018, 11:34 AM.

Details

Summary

Missing comma separator for EXIT and TAIL_EXIT RecordTypes emit invalid
JSON output for Chrome Trace Event Format.

Diff Detail

Repository
rL LLVM

Event Timeline

chris3k created this revision.Jul 23 2018, 11:34 AM
dberris accepted this revision.Jul 23 2018, 4:34 PM
dberris added subscribers: kpw, sammccall.

LGTM -- good catch, @chris3k.

@kpw, we probably should have tests to cover some more of these cases, now that @sammccall has landed the JSON parser/writer (and also probably move to using that instead of our own ad hoc implementation here).

This revision is now accepted and ready to land.Jul 23 2018, 4:34 PM

@chris3k -- do you already have commit access, or do you need someone else to land this for you?

Hi @dberris, I don't have commit access. Please land this change for me. Thank you and best regards.

This revision was automatically updated to reflect the committed changes.