Missing comma separator for EXIT and TAIL_EXIT RecordTypes emit invalid
JSON output for Chrome Trace Event Format.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM -- good catch, @chris3k.
@kpw, we probably should have tests to cover some more of these cases, now that @sammccall has landed the JSON parser/writer (and also probably move to using that instead of our own ad hoc implementation here).
Comment Actions
@chris3k -- do you already have commit access, or do you need someone else to land this for you?
Comment Actions
Hi @dberris, I don't have commit access. Please land this change for me. Thank you and best regards.