This is an archive of the discontinued LLVM Phabricator instance.

OpChain has subclasses, so add a virtual destructor.
ClosedPublic

Authored by rupprecht on Jul 23 2018, 10:33 AM.

Reviewers

Commits

Summary

OpChain has subclasses, so add a virtual destructor.

This fixes an issue when deleting subclasses of OpChain (see MatchSMLAD() specifically) in r337701.

Repository

rL LLVM

Build Status

Buildable 20612
Build 20612: arc lint + arc unit

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2018, 10:38 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Target/

ARM/

1 line

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines	namespace {
struct OpChain {		struct OpChain {
Instruction *Root;		Instruction *Root;
ValueList AllValues;		ValueList AllValues;
MemInstList VecLd; // List of all load instructions.		MemInstList VecLd; // List of all load instructions.
MemLocList MemLocs; // All memory locations read by this tree.		MemLocList MemLocs; // All memory locations read by this tree.
bool ReadOnly = true;		bool ReadOnly = true;

OpChain(Instruction *I, ValueList &vl) : Root(I), AllValues(vl) { }		OpChain(Instruction *I, ValueList &vl) : Root(I), AllValues(vl) { }
		virtual ~OpChain() = default;

void SetMemoryLocations() {		void SetMemoryLocations() {
const auto Size = MemoryLocation::UnknownSize;		const auto Size = MemoryLocation::UnknownSize;
for (auto *V : AllValues) {		for (auto *V : AllValues) {
if (auto *I = dyn_cast<Instruction>(V)) {		if (auto *I = dyn_cast<Instruction>(V)) {
if (I->mayWriteToMemory())		if (I->mayWriteToMemory())
ReadOnly = false;		ReadOnly = false;
if (auto *Ld = dyn_cast<LoadInst>(V))		if (auto *Ld = dyn_cast<LoadInst>(V))
▲ Show 20 Lines • Show All 599 Lines • Show Last 20 Lines