This is an archive of the discontinued LLVM Phabricator instance.

[profile] Fix a possible memory leak in parseFilenamePattern().
ClosedPublic

Authored by ikudrin on Jul 23 2018, 4:54 AM.

Reviewers

Commits

lgtm

This revision is now accepted and ready to land.Jul 23 2018, 8:19 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

profile/

4 lines

Show First 20 Lines • Show All 312 Lines • ▼ Show 20 Lines	static int parseFilenamePattern(const char *FilenamePat,
int MergingEnabled = 0;		int MergingEnabled = 0;

/* Clean up cached prefix and filename. */		/* Clean up cached prefix and filename. */
if (lprofCurFilename.ProfilePathPrefix)		if (lprofCurFilename.ProfilePathPrefix)
free((void *)lprofCurFilename.ProfilePathPrefix);		free((void *)lprofCurFilename.ProfilePathPrefix);
if (lprofCurFilename.Filename)		if (lprofCurFilename.Filename)
free((void *)lprofCurFilename.Filename);		free((void *)lprofCurFilename.Filename);

memset(&lprofCurFilename, 0, sizeof(lprofCurFilename));

if (lprofCurFilename.FilenamePat && lprofCurFilename.OwnsFilenamePat) {		if (lprofCurFilename.FilenamePat && lprofCurFilename.OwnsFilenamePat) {
free((void *)lprofCurFilename.FilenamePat);		free((void *)lprofCurFilename.FilenamePat);
}		}

		memset(&lprofCurFilename, 0, sizeof(lprofCurFilename));

if (!CopyFilenamePat)		if (!CopyFilenamePat)
lprofCurFilename.FilenamePat = FilenamePat;		lprofCurFilename.FilenamePat = FilenamePat;
else {		else {
lprofCurFilename.FilenamePat = strdup(FilenamePat);		lprofCurFilename.FilenamePat = strdup(FilenamePat);
lprofCurFilename.OwnsFilenamePat = 1;		lprofCurFilename.OwnsFilenamePat = 1;
}		}
/* Check the filename for "%p", which indicates a pid-substitution. */		/* Check the filename for "%p", which indicates a pid-substitution. */
for (I = 0; FilenamePat[I]; ++I)		for (I = 0; FilenamePat[I]; ++I)
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines