This was accidentally clobbering the input file, and never creating the
output file when using a second positional input parameter.
Details
Details
- Reviewers
alexander-shaposhnikov
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 20508 Build 20508: arc lint + arc unit
Event Timeline
Comment Actions
@srhines - i've just checked binutils strip again, so basically the positional arguments here are not "input" + "output", instead,
it's a list of "input" files which should be modified in-place.
For example, strip a.o b.o c.o should strip each of them.
Comment Actions
Gah, you are correct. Our Android build system had grown to depend on this behavior from llvm-strip previously. Doing an update now is how I am finding all of these issues. I'll fix it in our build system and abandon this CL. Thanks for the review.