This is an archive of the discontinued LLVM Phabricator instance.

Fix positional output argument for llvm-strip.
AbandonedPublic

Authored by srhines on Jul 19 2018, 4:16 AM.

Details

Summary

This was accidentally clobbering the input file, and never creating the
output file when using a second positional input parameter.

Diff Detail

Event Timeline

srhines created this revision.Jul 19 2018, 4:16 AM
srhines updated this revision to Diff 156233.Jul 19 2018, 4:30 AM

Switch to using .back() because I was lazy in the first upload. :)

alexander-shaposhnikov requested changes to this revision.Jul 19 2018, 10:47 AM

@srhines - i've just checked binutils strip again, so basically the positional arguments here are not "input" + "output", instead,
it's a list of "input" files which should be modified in-place.
For example, strip a.o b.o c.o should strip each of them.

This revision now requires changes to proceed.Jul 19 2018, 10:47 AM
srhines abandoned this revision.Jul 19 2018, 12:38 PM

Gah, you are correct. Our Android build system had grown to depend on this behavior from llvm-strip previously. Doing an update now is how I am finding all of these issues. I'll fix it in our build system and abandon this CL. Thanks for the review.