This is an archive of the discontinued LLVM Phabricator instance.

Differential D49481

Haiku: Enable thread-local storage and disable PIE by default
Needs RevisionPublic

Authored by kallisti5 on Jul 18 2018, 6:56 AM.

Download Raw Diff

Details

Reviewers

Diff Detail

Repository: rC Clang

Event Timeline

kallisti5 created this revision.Jul 18 2018, 6:56 AM

Herald added a subscriber: cfe-commits. · View Herald TranscriptJul 18 2018, 6:56 AM

The original author is "Jerome Duval <jerome.duval@gmail.com>" I don't have permission to modify this, can the author be updated?

Both needs a test case :)

This revision now requires changes to proceed.Jul 18 2018, 8:26 AM

brad changed the repository for this revision from rC Clang to rG LLVM Github Monorepo.Sep 1 2023, 4:09 PM

brad added a project: Restricted Project.

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 1 2023, 4:09 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

brad mentioned this in D159390: Haiku: Enable thread-local storag, disable PIE / enable PIC by default.Sep 1 2023, 4:14 PM

brad mentioned this in rG99be6b6d598f: Haiku: Enable thread-local storag, disable PIE / enable PIC by default.Sep 2 2023, 11:03 PM

This can be closed.

Revision Contents

Path

Size

lib/

Basic/

Targets/

1 line

Driver/

ToolChains/

4 lines

Diff 156061

lib/Basic/Targets/OSTargets.h

Context not available.
	this->IntPtrType = TargetInfo::SignedLong;			this->IntPtrType = TargetInfo::SignedLong;
	this->PtrDiffType = TargetInfo::SignedLong;			this->PtrDiffType = TargetInfo::SignedLong;
	this->ProcessIDType = TargetInfo::SignedLong;			this->ProcessIDType = TargetInfo::SignedLong;
	this->TLSSupported = false;
	}			}
	};			};

Context not available.

lib/Driver/ToolChains/Haiku.h

Context not available.
	Haiku(const Driver &D, const llvm::Triple &Triple,			Haiku(const Driver &D, const llvm::Triple &Triple,
	const llvm::opt::ArgList &Args);			const llvm::opt::ArgList &Args);

	bool isPIEDefault() const override {			bool isPIEDefault() const override { return false; }
	return getTriple().getArch() == llvm::Triple::x86_64;
	}

	void addLibCxxIncludePaths(			void addLibCxxIncludePaths(
	const llvm::opt::ArgList &DriverArgs,			const llvm::opt::ArgList &DriverArgs,
Context not available.