Page MenuHomePhabricator
Differential D49376

[NEON] Define half-precision vrnd intrinsics only when available
ClosedPublic
Actions

Authored by kosarev on Jul 16 2018, 7:31 AM.

Details

Reviewers
SjoerdMeijer
jgreenhalgh
rengolin
javed.absar
Commits
rC337699: [NEON] Define half-precision vrnd intrinsics only when available
rG26037539e432: [NEON] Define half-precision vrnd intrinsics only when available
rL337699: [NEON] Define half-precision vrnd intrinsics only when available

Diff Detail

Repository
rC Clang

Event Timeline

kosarev created this revision.Jul 16 2018, 7:31 AM
SjoerdMeijer accepted this revision.Jul 23 2018, 1:41 AM

LGTM

include/clang/Basic/arm_neon.td
1420–1427

nit: is the indentation a bit off here?

This revision is now accepted and ready to land.Jul 23 2018, 1:41 AM
kosarev added inline comments.Jul 23 2018, 6:35 AM
include/clang/Basic/arm_neon.td
1420–1427

It's a nested let ArchGuard, so I guess we do want the indentation here?

SjoerdMeijer added inline comments.Jul 23 2018, 6:43 AM
include/clang/Basic/arm_neon.td
1420–1427

Yep, got confused, please ignore.

Closed by commit rC337699: [NEON] Define half-precision vrnd intrinsics only when available (authored by kosarev, committed by ). · Explain WhyJul 23 2018, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Minclude/clang/Basic/arm_neon.td (14 lines)
Mtest/Sema/arm-no-fp16.c (56 lines)

Diff 156790

View Options

include/clang/Basic/arm_neon.td

Loading...
View Options

test/Sema/arm-no-fp16.c

Loading...