Page MenuHomePhabricator

[cfi-verify] Abort on unsupported targets
ClosedPublic

Authored by jgalenson on Jul 13 2018, 9:59 AM.

Details

Summary

As suggested in the review for r337007, this makes cfi-verify abort on unsupported targets instead of producing incorrect results. It also updates the design document to reflect this.

Note that I'm not sure if 32-bit x86 is supported. We don't seem to have any tests for it, but I tried a toy example and it worked, so I left it there. What do you think?

Diff Detail

Repository
rL LLVM

Event Timeline

jgalenson created this revision.Jul 13 2018, 9:59 AM

I think leaving x86 in there is reasonable.

This revision is now accepted and ready to land.Jul 13 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.