This is an archive of the discontinued LLVM Phabricator instance.

[mips64][clang] Provide the signext attribute for i32 return values
ClosedPublic

Authored by smaksimovic on Jul 13 2018, 5:05 AM.

Reviewers

Commits

Summary

Patch for the backend part of the problem here: D48374

LGTM

This revision is now accepted and ready to land.Jul 29 2018, 1:56 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

CodeGen/

10 lines

Show First 20 Lines • Show All 6,979 Lines • ▼ Show 20 Lines	if (isAggregateTypeForABI(RetTy) \|\| RetTy->isVectorType()) {

return getNaturalAlignIndirect(RetTy);		return getNaturalAlignIndirect(RetTy);
}		}

// Treat an enum type as its underlying type.		// Treat an enum type as its underlying type.
if (const EnumType *EnumTy = RetTy->getAs<EnumType>())		if (const EnumType *EnumTy = RetTy->getAs<EnumType>())
RetTy = EnumTy->getDecl()->getIntegerType();		RetTy = EnumTy->getDecl()->getIntegerType();

return (RetTy->isPromotableIntegerType() ? ABIArgInfo::getExtend(RetTy)		if (RetTy->isPromotableIntegerType())
: ABIArgInfo::getDirect());		return ABIArgInfo::getExtend(RetTy);

		if ((RetTy->isUnsignedIntegerOrEnumerationType() \|\|
		RetTy->isSignedIntegerOrEnumerationType()) && Size == 32 && !IsO32)
		return ABIArgInfo::getSignExtend(RetTy);

		return ABIArgInfo::getDirect();
}		}

void MipsABIInfo::computeInfo(CGFunctionInfo &FI) const {		void MipsABIInfo::computeInfo(CGFunctionInfo &FI) const {
ABIArgInfo &RetInfo = FI.getReturnInfo();		ABIArgInfo &RetInfo = FI.getReturnInfo();
if (!getCXXABI().classifyReturnType(FI))		if (!getCXXABI().classifyReturnType(FI))
RetInfo = classifyReturnType(FI.getReturnType());		RetInfo = classifyReturnType(FI.getReturnType());

// Check if a pointer to an aggregate is passed as a hidden argument.		// Check if a pointer to an aggregate is passed as a hidden argument.
▲ Show 20 Lines • Show All 2,285 Lines • Show Last 20 Lines