Add new SBTarget::IsDummy method.

[apolyakov]

Summary

The new member function allows to check if a target is dummy or real.
It is useful for commands that can't be executed on the dummy target.
For instance: symbol-list-lines command.

[brucem]

include/lldb/API/SBTarget.h

65

Could you add a doc comment here explaining it?

scripts/interface/SBTarget.i

85

And here as well?

[apolyakov]

Added description to source files and commit message.

[aprantl]

Is the dummy target something we need to expose over the SBAPI?
I see that other places in lldb-mi query if (sbTarget == rSessionInfo.GetDebugger().GetDummyTarget()). Would that be sufficient?

[apolyakov]

I think we can remove comments added by me and commit patch as it is. Any thoughts about it?

[aprantl]

Have you seen my earlier question:

Is the dummy target something we need to expose over the SBAPI?
I see that other places in lldb-mi query if (sbTarget == rSessionInfo.GetDebugger().GetDummyTarget()).
Would that be sufficient?

[apolyakov]

It's hard to choose something, both variants are good enough. But, if there is no necessity in such a method, we can drop it.

[aprantl]

Okay then let's not do this for now. It's fine to revisit this later if there turns out to be a good use-case for it, but every SBAPI call we introduce has to be supported indefinitely and can therefore be quite expensive to maintain.

[apolyakov]

Abandoned since suggested functionality is optional.

include/lldb/API/SBTarget.h

public:
   // Destructor
   //------------------------------------------------------------------
   ~SBTarget();
 
   const lldb::SBTarget &operator=(const lldb::SBTarget &rhs);
 
   bool IsValid() const;
 
+  // Returns true if *this target is a dummy one, false otherwise.
+  bool IsDummy() const;
+
   static bool EventIsTargetEvent(const lldb::SBEvent &event);
 
   static lldb::SBTarget GetTargetFromEvent(const lldb::SBEvent &event);
 
   static uint32_t GetNumModulesFromEvent(const lldb::SBEvent &event);
 
   static lldb::SBModule GetModuleAtIndexFromEvent(const uint32_t idx,
                                                   const lldb::SBEvent &event);

scripts/interface/SBTarget.i

public:
     ~SBTarget();
 
     static const char *
     GetBroadcasterClassName ();
 
     bool
     IsValid() const;
 
+    %feature("docstring",
+    "Returns true if *this target is a dummy one, false otherwise.") IsDummy;
+    bool
+    IsDummy () const;
+
     static bool
     EventIsTargetEvent (const lldb::SBEvent &event);
 
     static lldb::SBTarget
     GetTargetFromEvent (const lldb::SBEvent &event);
 
     static uint32_t
     GetNumModulesFromEvent (const lldb::SBEvent &event);

source/API/SBTarget.cpp

 const char *SBTarget::GetBroadcasterClassName() {
   return Target::GetStaticBroadcasterClass().AsCString();
 }
 
 bool SBTarget::IsValid() const {
   return m_opaque_sp.get() != NULL && m_opaque_sp->IsValid();
 }
 
+bool SBTarget::IsDummy() const {
+  return *this == GetDebugger().GetDummyTarget();
+}
+
 SBProcess SBTarget::GetProcess() {
   SBProcess sb_process;
   ProcessSP process_sp;
   TargetSP target_sp(GetSP());
   if (target_sp) {
     process_sp = target_sp->GetProcessSP();
     sb_process.SetSP(process_sp);
   }