This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix ordering of device-lib linking
ClosedPublic

Authored by ashi1 on Jun 27 2018, 12:15 PM.

Reviewers

yaxunl
b-sumner

Commits

Summary

Should link the bitcodes with caller functions before callee functions.

Thanks, looks good.

Please add a lit test.

Updated diff with a lit test.

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 27 2018, 12:54 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Driver/

ToolChains/

2 lines

test/

Driver/

1 line

Context not available.
	FlushDenormalControlBC = "oclc_daz_opt_off.amdgcn.bc";	FlushDenormalControlBC = "oclc_daz_opt_off.amdgcn.bc";

	BCLibs.append({"opencl.amdgcn.bc",	BCLibs.append({"opencl.amdgcn.bc",
	"ockl.amdgcn.bc", "irif.amdgcn.bc", "ocml.amdgcn.bc",	"ocml.amdgcn.bc", "ockl.amdgcn.bc", "irif.amdgcn.bc",
	"oclc_finite_only_off.amdgcn.bc",	"oclc_finite_only_off.amdgcn.bc",
	FlushDenormalControlBC,	FlushDenormalControlBC,
	"oclc_correctly_rounded_sqrt_on.amdgcn.bc",	"oclc_correctly_rounded_sqrt_on.amdgcn.bc",
Context not available.

Context not available.


	// COM: [[LLVM_LINK:"*.llvm-link"]]	// COM: [[LLVM_LINK:"*.llvm-link"]]
		// COM-SAME: {{.}} "{{.}}ocml.amdgcn.bc" "{{.}}ockl.amdgcn.bc" "{{.}}irif.amdgcn.bc"
	// FLUSHD-SAME: {{.}} "{{.}}oclc_daz_opt_on.amdgcn.bc"	// FLUSHD-SAME: {{.}} "{{.}}oclc_daz_opt_on.amdgcn.bc"
	// NOFLUSHD-SAME: {{.}} "{{.}}oclc_daz_opt_off.amdgcn.bc"	// NOFLUSHD-SAME: {{.}} "{{.}}oclc_daz_opt_off.amdgcn.bc"
	// COM-SAME: {{.}} "-o" "{{.}}-gfx900-linked-{{.*bc}}"	// COM-SAME: {{.}} "-o" "{{.}}-gfx900-linked-{{.*bc}}"
Context not available.