Page MenuHomePhabricator

[HIP] Fix ordering of device-lib linking
ClosedPublic

Authored by ashi1 on Jun 27 2018, 12:15 PM.

Diff Detail

Repository
rC Clang

Event Timeline

ashi1 created this revision.Jun 27 2018, 12:15 PM

Thanks, looks good.

Please add a lit test.

ashi1 updated this revision to Diff 153154.Jun 27 2018, 12:34 PM

Updated diff with a lit test.

yaxunl accepted this revision.Jun 27 2018, 12:54 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jun 27 2018, 12:54 PM
Closed by commit rC335774: [HIP] Fix ordering of device-libs linking (authored by aaronenyeshi, committed by ). · Explain WhyJun 27 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.