Page MenuHomePhabricator

Do not sext i1 constants when selecting binary ops
AbandonedPublic

Authored by draganm on Jun 27 2018, 4:27 AM.

Details

Reviewers
mcrosier
Summary

MipsFastISel comparison lowering relies on i1 values allways being 1 or 0 zero extended which can be broken by [X]OR binop.
I chose to fix it here because it gives a slightly better codegen on MIPS.

Diff Detail

Repository
rL LLVM

Event Timeline

draganm created this revision.Jun 27 2018, 4:27 AM
petarj added a subscriber: petarj.Jun 29 2018, 10:07 AM
draganm abandoned this revision.Jul 13 2018, 2:32 AM

Closing in favor of fixing this in Mips back-end.