This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Enable Scudo memory hooks for Fuchsia.
ClosedPublic

Authored by flowerhack on Jun 26 2018, 4:31 PM.

Details

Summary
It would be useful for Flutter apps, especially, to be able to use
malloc hooks to debug memory leaks on Fuchsia. They're not able to do
this right now, so it'd be a nice bonus to throw in with the Scudo
switchover.

Diff Detail

Event Timeline

flowerhack created this revision.Jun 26 2018, 4:31 PM
cryptoad accepted this revision.Jun 26 2018, 5:52 PM

Or maybe wrap it all with # define SCUDO_CAN_USE_HOOKS (SANITIZER_FUCHSIA) or equivalent if it looks cleaner. Up to you.

This revision is now accepted and ready to land.Jun 26 2018, 5:52 PM

I like that this matches the style of the SCUDO_SHARED_TSD_POOL_SIZE enables, so I may leave it as-is, if that's alright with you.

I like that this matches the style of the SCUDO_SHARED_TSD_POOL_SIZE enables, so I may leave it as-is, if that's alright with you.

Yup!

This revision was automatically updated to reflect the committed changes.
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptJul 2 2018, 12:52 PM