This is an archive of the discontinued LLVM Phabricator instance.

[AliasSet] Fix UnknownInstructions printing
ClosedPublic

Authored by kuhar on Jun 26 2018, 2:51 PM.

Details

Summary

AliasSet::print uses I->printAsOperand to print UnknownInstructions. The problem is that not all UnknownInstructions have names (e.g. call instructions). When such instructions are printed, they appear as <badref> in AliasSets, which is very confusing, as the values are perfectly valid.

This patch fixes that by printing UnknownInstructions without a name using print instead of printAsOperand.

Diff Detail

Repository
rL LLVM

Event Timeline

kuhar created this revision.Jun 26 2018, 2:51 PM
asbirlea accepted this revision.Jun 26 2018, 3:07 PM

LGTM.

This revision is now accepted and ready to land.Jun 26 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.