Handle NetBSD specific path in findDebugBinary()

[krytarowski]

Summary

The NetBSD Operating System installs debuginfo
files into /usr/libdata/debug, rather than other path
like in some other popular distribution.

This change makes llvm-symbolizer functional with
the basesystem executables.

[vitalybuka]

lib/DebugInfo/Symbolize/Symbolize.cpp

195 ↗

(On Diff #152608)

Can we just try both paths and have the same behavior everywhere?

[krytarowski]

lib/DebugInfo/Symbolize/Symbolize.cpp

195 ↗

(On Diff #152608)

A similar ifdef is in LLDB.. but I will change the code to try out both paths.

[vitalybuka]

lib/DebugInfo/Symbolize/Symbolize.cpp

195 ↗

(On Diff #152608)

Thanks. I'd prefer version without ifdef.
But if you get pushback from lldb, please just make it consistent.

[vitalybuka]

lgtm in any case

[krytarowski]

lib/DebugInfo/Symbolize/Symbolize.cpp

195 ↗

(On Diff #152608)

I will go for ifdef, as [likely] /usr/libdata will be never valid for others and /usr/lib never valid for NetBSD.

llvm/trunk/lib/DebugInfo/Symbolize/Symbolize.cpp

#endif
   }
   // Try /path/to/original_binary/.debug/debuglink_name
   DebugPath = OrigDir;
   llvm::sys::path::append(DebugPath, ".debug", DebuglinkName);
   if (checkFileCRC(DebugPath, CRCHash)) {
     Result = DebugPath.str();
     return true;
   }
+#if defined(__NetBSD__)
+  // Try /usr/libdata/debug/path/to/original_binary/debuglink_name
+  DebugPath = "/usr/libdata/debug";
+#else
   // Try /usr/lib/debug/path/to/original_binary/debuglink_name
   DebugPath = "/usr/lib/debug";
+#endif
   llvm::sys::path::append(DebugPath, llvm::sys::path::relative_path(OrigDir),
                           DebuglinkName);
   if (checkFileCRC(DebugPath, CRCHash)) {
     Result = DebugPath.str();
     return true;
   }
   return false;
 }