[test-suite] Set the language standard for SPEC benchmarks that do not compile using the newest.

[Meinersbur]

Summary

Clang's default dialect has changed to -std=gnu++14 in r320250. Some of the SPEC benchmarks do not compile with this change. Set the language version to C++ 98 (the previous default) explicitly for these benchmarks.

[MatzeB]

LGTM

[evandro]

test-suite/trunk/External/SPEC/CINT2006/473.astar/CMakeLists.txt

1

Should this be c++03 instead?

[Meinersbur]

test-suite/trunk/External/SPEC/CINT2006/473.astar/CMakeLists.txt

1

-std=gnu++98 was the setting before changed in rL320250. It does not rely on gnu extensions so I picked -std=c++98.

What is your your argument to use -std=c++03 instead?

[evandro]

test-suite/trunk/External/SPEC/CINT2006/473.astar/CMakeLists.txt

1

It's what some internal scripts of ours use. Unfortunately, none of us could recall why C++03 was chosen. Digging the SPEC CPU2006 distro, it seems that it was released with example configuration files supporting GCC versions like 4.1 and 4.3, which only supported C++98. So, I agree with your choice.

test-suite/trunk/External/SPEC/CFP2017rate/510.parest_r/CMakeLists.txt

speccpu2017_add_executable(
   source/libparest/slave/stationary/global_matrix.cc
   source/libparest/slave/stationary/grid_refinement.cc
   source/libparest/slave/stationary/measurements.cc
   source/libparest/slave/stationary/problem_description.cc
   source/libparest/slave/stationary/slave.cc
   source/libparest/slave/stationary/state_discretization.cc
   source/libparest/slave/stationary/synthetic_data.cc
 )
+set_property(TARGET ${PROG} PROPERTY CXX_STANDARD 98)

test-suite/trunk/External/SPEC/CFP2017rate/526.blender_r/CMakeLists.txt

   libpng/pngwrite.c
   libpng/pngrtran.c
   libpng/pngwtran.c
   libpng/pngrio.c
   libpng/pngwio.c
   specrand/specrand.c
   spec_backtrace.c
 )
+set_property(TARGET ${PROG} PROPERTY CXX_STANDARD 98)
 speccpu2017_prepare_rundir()

test-suite/trunk/External/SPEC/CINT2006/473.astar/CMakeLists.txt

+list(APPEND CPPFLAGS -std=c++98)
+
 macro(test_input run_type input output)
   llvm_test_run(RUN_TYPE ${run_type}
     ${input}
     > ${CMAKE_CURRENT_BINARY_DIR}/${output}
     WORKDIR ${BENCHMARK_DIR}/data/${run_type}/input
   )
   llvm_test_verify(RUN_TYPE ${run_type} ${FPCMP}
     -r 0.001