Page MenuHomePhabricator

[libFuzzer] Initial implementation of mutation usefulness percentages.
AbandonedPublic

Authored by kodewilliams on Jun 19 2018, 2:07 PM.

Details

Reviewers
Dor1s
metzman
Summary

Now, the mutation statistics are displayed in a concise manner, along with the usefulness percentages below.

Diff Detail

Event Timeline

kodewilliams created this revision.Jun 19 2018, 2:07 PM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptJun 19 2018, 2:07 PM
Dor1s added a comment.Jun 19 2018, 2:53 PM

Hey Kode, is this ready for review, or you've just uploaded it for yourself? Next time, just leave a comment like "please take a look" or "PTAL" or "ready for review", so Jonathan and I can look at it without asking that question. Otherwise, we usually assume that it's a temporary version that may not necessary need our attention.

Another comment would be, please format commit title and description to be more consistent for other libFuzzer commits. Take a look at other commit messages for an example: https://github.com/llvm-mirror/compiler-rt/commits/master/lib/fuzzer

I assumed I was supposed to review this. +1 to Max's comment about saying "PTAL"
I don't really think this should be its own option. I'd just print the percentages, but I think this is for Max to decide since he has in mind what will be done with the stats better than I.

lib/fuzzer/FuzzerInternal.h
83

I think it would better if PrintFinalStats handled printing of all stats including the mutation ones, instead of calling these three functions all over.

lib/fuzzer/FuzzerMutationStats.cpp
70

This looks like an unnecessary change, please undo

Dor1s added a comment.Jun 19 2018, 3:02 PM

...
I don't really think this should be its own option. I'd just print the percentages, but I think this is for Max to decide since he has in mind what will be done with the stats better than I.

Fair point. Yeah, let's print both using the same flag (i.e. PrintMutationStats). At the end of the day, I think, we may remove the detailed information with mutation names at all, but it might be useful in the meantime while we're testing the things.

kodewilliams retitled this revision from Adding mutation usefulness metric to [libFuzzer] Initial implementation of mutation usefulness percentages..Jun 19 2018, 3:13 PM
kodewilliams edited the summary of this revision. (Show Details)
Dor1s added a comment.Jun 20 2018, 8:23 AM

Please take a look at my comment to your previous CL: https://reviews.llvm.org/D48054#1137281

Let's incorporate this changes into that CL as well, that would be much simpler in terms of adding a test and getting it landed.

kodewilliams abandoned this revision.Jun 20 2018, 1:13 PM
kodewilliams marked 2 inline comments as done.

Working on previous CL instead.