This is an archive of the discontinued LLVM Phabricator instance.

Differential D48226

[lldb] Remove enableThreadSanitizer from shared Xcode schemes
ClosedPublic

Authored by kubamracek on Jun 15 2018, 9:48 AM.

Details

Reviewers
jingham
jasonmolenda
aprantl
Summary

I think this was committed accidentally and default Xcode builds of LLDB now have TSan on. Let's turn it off.

Diff Detail

Event Timeline

kubamracek created this revision.Jun 15 2018, 9:48 AM
kubamracek added a subscriber: lldb-commits.
kubamracek added a reviewer: aprantl.Oct 23 2018, 9:03 PM

Ping.

aprantl accepted this revision.Oct 24 2018, 8:52 AM

Seems reasonable.

This revision is now accepted and ready to land.Oct 24 2018, 8:52 AM
kubamracek closed this revision.Oct 24 2018, 9:01 AM

r345155.

Revision Contents

PathSize
lldb.xcodeproj/
xcshareddata/
xcschemes/
1 line
1 line

Diff 151528

lldb.xcodeproj/xcshareddata/xcschemes/LLDB.xcscheme

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines <TestAction
</AdditionalOptions> </AdditionalOptions>
</TestAction> </TestAction>
<LaunchAction <LaunchAction
buildConfiguration = "Debug" buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
displayScaleIsEnabled = "NO" displayScaleIsEnabled = "NO"
displayScale = "1.00" displayScale = "1.00"
enableThreadSanitizer = "YES"
launchStyle = "0" launchStyle = "0"
useCustomWorkingDirectory = "NO" useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO" ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES" debugDocumentVersioning = "YES"
debugServiceExtension = "internal" debugServiceExtension = "internal"
allowLocationSimulation = "YES" allowLocationSimulation = "YES"
queueDebuggingEnabled = "No"> queueDebuggingEnabled = "No">
<BuildableProductRunnable <BuildableProductRunnable
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

lldb.xcodeproj/xcshareddata/xcschemes/darwin-debug.xcscheme

Show All 39 Lines <TestAction
</AdditionalOptions> </AdditionalOptions>
</TestAction> </TestAction>
<LaunchAction <LaunchAction
buildConfiguration = "Debug" buildConfiguration = "Debug"
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
displayScaleIsEnabled = "NO" displayScaleIsEnabled = "NO"
displayScale = "1.00" displayScale = "1.00"
enableThreadSanitizer = "YES"
launchStyle = "0" launchStyle = "0"
useCustomWorkingDirectory = "NO" useCustomWorkingDirectory = "NO"
ignoresPersistentStateOnLaunch = "NO" ignoresPersistentStateOnLaunch = "NO"
debugDocumentVersioning = "YES" debugDocumentVersioning = "YES"
debugServiceExtension = "internal" debugServiceExtension = "internal"
allowLocationSimulation = "YES" allowLocationSimulation = "YES"
queueDebuggingEnabled = "No"> queueDebuggingEnabled = "No">
<BuildableProductRunnable <BuildableProductRunnable
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines