Page MenuHomePhabricator

Fix when LLVM_USE_INTEL_JITEVENTS and LLVM_USE_OPROFILE not set, llvm-build not gen LibraryDependencies.inc
ClosedPublic

Authored by fcharlie on Jun 9 2018, 5:09 AM.

Details

Summary

If LLVM_USE_INTEL_JITEVENTS and LLVM_USE_OPROFILE not set, "${LLVMOPTIONALCOMPONENTS}" is empty, but --enable-optional-components need arg, Cause --write-library-table to be skipped parsed.

My CMake version: 3.11.2

execute_process(
  COMMAND ${PYTHON_EXECUTABLE} -B ${LLVMBUILDTOOL}
            --native-target "${LLVM_NATIVE_ARCH}"
            --enable-targets "${LLVM_TARGETS_TO_BUILD}"
            --enable-optional-components "${LLVMOPTIONALCOMPONENTS}"
            --write-library-table ${LLVMCONFIGLIBRARYDEPENDENCIESINC}
            --write-cmake-fragment ${LLVMBUILDCMAKEFRAG}
            OUTPUT_VARIABLE LLVMBUILDOUTPUT
            ERROR_VARIABLE LLVMBUILDERRORS
            OUTPUT_STRIP_TRAILING_WHITESPACE
            ERROR_STRIP_TRAILING_WHITESPACE
  RESULT_VARIABLE LLVMBUILDRESULT)

Diff Detail

Repository
rL LLVM

Event Timeline

fcharlie created this revision.Jun 9 2018, 5:09 AM
fcharlie edited the summary of this revision. (Show Details)Jun 9 2018, 5:09 AM
fcharlie added a reviewer: rnk.Jun 9 2018, 4:04 PM
rnk accepted this revision.Jun 11 2018, 9:51 AM

lgtm

This revision is now accepted and ready to land.Jun 11 2018, 9:51 AM

@rnk Please commit this, Thanks

This revision was automatically updated to reflect the committed changes.