Page MenuHomePhabricator

[Mips] Silencing warnings in instruction info (NFC)
ClosedPublic

Authored by NikolaPrica on Jun 7 2018, 4:55 AM.

Details

Summary

isORCopyInst and isReadOrWriteToDSPReg functions were producing warning that some statements my fall through.

Diff Detail

Repository
rL LLVM

Event Timeline

NikolaPrica created this revision.Jun 7 2018, 4:55 AM
sdardis accepted this revision.Jun 7 2018, 5:21 AM
sdardis added a reviewer: sdardis.
This revision is now accepted and ready to land.Jun 7 2018, 5:21 AM
atanasyan added inline comments.Jun 7 2018, 5:27 AM
lib/Target/Mips/MipsSEInstrInfo.cpp
211 ↗(On Diff #150298)

I would set isWrite = false here so this function always returns a correct value for the isWrite and does not have to rely on proper initialization of the isWrite before calling.

This revision was automatically updated to reflect the committed changes.