Differential D47825

[Mem2Reg] Avoid replacing load with itself in promoteSingleBlockAlloca.
ClosedPublic
Actions

Authored by fhahn on Jun 6 2018, 7:25 AM.

Tags

None

Subscribers

Details

Reviewers

chandlerc
davide
efriedma

Commits

rG0d6b01761c1d: [Mem2Reg] Avoid replacing load with itself in promoteSingleBlockAlloca.
rL334187: [Mem2Reg] Avoid replacing load with itself in promoteSingleBlockAlloca.

Summary

We do the same thing in rewriteSingleStoreAlloca.

Fixes PR37632.

Diff Detail

Repository: rL LLVM

Event Timeline

fhahn created this revision.Jun 6 2018, 7:25 AM

It seems reasonable to me.

This revision is now accepted and ready to land.Jun 6 2018, 7:45 AM

Closed by commit rL334187: [Mem2Reg] Avoid replacing load with itself in promoteSingleBlockAlloca. (authored by fhahn). · Explain WhyJun 7 2018, 4:13 AM

This revision was automatically updated to reflect the committed changes.

kbelochapka mentioned this in D43544: [Transforms][SROA] Fixed assertion crash (PR30416).Oct 15 2020, 7:55 PM

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

lib/

Transforms/

Utils/

PromoteMemoryToRegister.cpp

5 lines

test/

Transforms/

Mem2Reg/

pr37632-unreachable-list-of-stores.ll

20 lines

Diff 150293

llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

Loading...

llvm/trunk/test/Transforms/Mem2Reg/pr37632-unreachable-list-of-stores.ll

Loading...