LGTM, with the suggested changes.
|7 ↗||(On Diff #150102)|
Please put a new line in before this line. It'll help make the llvm-strip part clearer.
|8–9 ↗||(On Diff #150102)|
You don't need to copy the input file here, since we don't use it again at this point.
|586 ↗||(On Diff #150102)|
This comment looks a little out of place now with the changes you and @alexshap are making in this area. It probably needs updating or (re)moving.
Hey I'm away but I got a bug report requesting -x as an alias in
llvm-strip. I haven't looked at the code for this patch so it might already
be solved here but I'd appreciate it being added. No worries either way.
I'll just add it when aight get back of it isn't there.