This is an archive of the discontinued LLVM Phabricator instance.

Differential D47490

Use -Wextra spelling instead of -W
ClosedPublic

Authored by thakis on May 29 2018, 11:28 AM.

Details

Reviewers
rnk
Summary

No difference in behavior, but a bit easier to search for.

Diff Detail

Event Timeline

thakis created this revision.May 29 2018, 11:28 AM
Herald added a subscriber: mgorny. · View Herald TranscriptMay 29 2018, 11:28 AM
rnk accepted this revision.May 29 2018, 11:31 AM

lgtm

This revision is now accepted and ready to land.May 29 2018, 11:31 AM
thakis closed this revision.May 31 2018, 6:45 AM

r333651, thanks!

Revision Contents

PathSize
cmake/
modules/
2 lines

Diff 148953

cmake/modules/HandleLLVMOptions.cmake

Context not available.
append("-Wall" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append("-Wall" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
endif() endif()
append("-W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append("-Wextra -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append("-Wcast-qual" CMAKE_CXX_FLAGS) append("-Wcast-qual" CMAKE_CXX_FLAGS)
# Turn off missing field initializer warnings for gcc to avoid noise from # Turn off missing field initializer warnings for gcc to avoid noise from
Context not available.