This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Corrections for MiniGMG
ClosedPublic

Authored by homerdin on May 29 2018, 9:24 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

homerdin created this revision.May 29 2018, 9:24 AM
hfinkel added inline comments.May 30 2018, 6:38 PM
mg.c
103 ↗(On Diff #148924)

Why are you changing the number of periods in the printf strings (here and below)? Is this change necessary?

homerdin updated this revision to Diff 149288.May 31 2018, 7:08 AM

I had removed the periods after getting a FP Comparison failed, not a numeric difference between '.' and '.' " error. They were not the issue and I have added them back in.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 18 2018, 9:00 AM
This revision was automatically updated to reflect the committed changes.

This seems to break here: http://green.lab.llvm.org/green/job/lnt-test-suite-x86_64-Os-flto/3288/consoleFull

/Users/buildslave/jenkins/workspace/lnt-test-suite-x86_64-Os-flto/lnt-sandbox/build/tools/fpcmp: Compared: 4.440892e-16 and -1.110223e-15
abs. diff = 1.554312e-15 rel.diff = 1.400000e+00
Out of tolerance: rel/abs: 1.000000e-05/0.000000e+00

Can you please take a look @homerdin or revert it? Thanks!

I reverted both commits in r335009 and r335010 to fix the bots.

Ah, sorry, I just saw that your second commit fixed the issue. Relanded in:

https://reviews.llvm.org/rL335012

and

https://reviews.llvm.org/rL335011.