[Sparc] Let llvm-objdump show symbol and addend for Sparc relocations

[jyknight]

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

[dcederman]

In D47457#1114658, @jyknight wrote:

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

Yes, changing the defaults seems like a better approach. Could you clarify what you mean by "take it over"? I tried updating the other revision with the changes you suggested, but you I could not find a way to do it. Phabricator only seems to allow me to change my own revisions.

[jrtc27]

In D47457#1116220, @dcederman wrote:

In D47457#1114658, @jyknight wrote:

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

Yes, changing the defaults seems like a better approach. Could you clarify what you mean by "take it over"? I tried updating the other revision with the changes you suggested, but you I could not find a way to do it. Phabricator only seems to allow me to change my own revisions.

It's the "Commandeer Revision" action in the "Add Action..." drop-down above the comment box.

[dcederman]

In D47457#1116377, @jrtc27 wrote:

It's the "Commandeer Revision" action in the "Add Action..." drop-down above the comment box.

Thanks!

test/MC/Sparc/sparc-tls-relocations.s

 foo:
 ! Here we use two different sequences to get the address of a static TLS variable 'Head'
 ! (note - there is no intent to have valid assembler function here,
 !  we just check how TLS relocations are emitted)
 !
 ! First sequence uses LE_HIX22/LE_LOX10
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  31 00 00 00  sethi 0, %i0
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LE_HIX22 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LE_HIX22 Head
 ! ASM: sethi %tle_hix22(Head), %i0 ! encoding: [0x31,0x00,0x00,0x00]
 ! ASM:                                 !   fixup A - offset: 0, value: %tle_hix22(Head), kind: fixup_sparc_tls_le_hix22
         sethi %tle_hix22(Head), %i0
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  b0 1e 20 00  xor %i0, 0, %i0
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LE_LOX10 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LE_LOX10 Head
 ! ASM: xor %i0, %tle_lox10(Head), %i0 ! encoding: [0xb0,0x1e,0x20,0x00]
 ! ASM:                                    !   fixup A - offset: 0, value: %tle_lox10(Head), kind: fixup_sparc_tls_le_lox10
         xor %i0, %tle_lox10(Head), %i0
 
 
 ! Second sequence is for PIC, so it is more complicated.
 ! It uses LDO_HIX22/LDO_LOX10/LDO_ADD/LDM_HI22/LDM_LO10/LDM_ADD/LDM_CALL
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  33 00 00 00  sethi 0, %i1
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDO_HIX22 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDO_HIX22 Head
 ! ASM: sethi %tldo_hix22(Head), %i1 ! encoding: [0x33,0b00AAAAAA,A,A]
 ! ASM:                                  !   fixup A - offset: 0, value: %tldo_hix22(Head), kind: fixup_sparc_tls_ldo_hix22
         sethi %tldo_hix22(Head), %i1
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  35 00 00 00  sethi 0, %i2
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDM_HI22 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDM_HI22 Head
 ! ASM: sethi %tldm_hi22(Head), %i2 ! encoding: [0x35,0b00AAAAAA,A,A]
 ! ASM:                                 !   fixup A - offset: 0, value: %tldm_hi22(Head), kind: fixup_sparc_tls_ldm_hi22
         sethi %tldm_hi22(Head), %i2
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  b4 06 a0 00  add %i2, 0, %i2
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDM_LO10 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDM_LO10 Head
 ! ASM: add %i2, %tldm_lo10(Head), %i2 ! encoding: [0xb4,0x06,0b101000AA,A]
 ! ASM:                                    !   fixup A - offset: 0, value: %tldm_lo10(Head), kind: fixup_sparc_tls_ldm_lo10
         add %i2, %tldm_lo10(Head), %i2
 
   ! ???error from llvm-mc on the next asm line???
   ! add %i0, %i2, %o0, %tldm_add(Head)
 
 ! OBJDUMP: {{[0-9,a-f]+}}:  b0 1e 60 00  xor %i1, 0, %i0
-! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDO_LOX10 Unknown
+! OBJDUMP: {{[0-9,a-f]+}}:     R_SPARC_TLS_LDO_LOX10 Head
 ! ASM: xor %i1, %tldo_lox10(Head), %i0 ! encoding: [0xb0,0x1e,0b011000AA,A]
 ! ASM:                                     !   fixup A - offset: 0, value: %tldo_lox10(Head), kind: fixup_sparc_tls_ldo_lox10
         xor %i1, %tldo_lox10(Head), %i0
 
         ! ???error from llvm-mc on the next asm line???
         ! call __tls_get_addr, %tldm_call(Head)
         ! nop
         ! ???error from llvm-mc on the next asm line???
         ! add %o0, %i0, %i0, %tldo_add(Head)
 
         .type  Head,@object
         .section      .tbss,#alloc,#write,#tls
 Head:
         .word  0
         .size  Head, 4

tools/llvm-objdump/llvm-objdump.cpp

case ELF::R_X86_64_64: {
       fmt << Target << (addend < 0 ? "" : "+") << addend;
       fmt.flush();
       Result.append(fmtbuf.begin(), fmtbuf.end());
     } break;
     default:
       res = "Unknown";
     }
     break;
+  case ELF::EM_SPARC:
+  case ELF::EM_SPARCV9:
   case ELF::EM_LANAI:
   case ELF::EM_AVR:
   case ELF::EM_AARCH64: {
     std::string fmtbuf;
     raw_string_ostream fmt(fmtbuf);
     fmt << Target;
     if (addend != 0)
       fmt << (addend < 0 ? "" : "+") << addend;