Page MenuHomePhabricator

[Sparc] Let llvm-objdump show symbol and addend for Sparc relocations
AbandonedPublic

Authored by dcederman on May 29 2018, 1:07 AM.

Details

Reviewers
jyknight
venkatra

Diff Detail

Event Timeline

dcederman created this revision.May 29 2018, 1:07 AM

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

Yes, changing the defaults seems like a better approach. Could you clarify what you mean by "take it over"? I tried updating the other revision with the changes you suggested, but you I could not find a way to do it. Phabricator only seems to allow me to change my own revisions.

Related: https://reviews.llvm.org/D36464. I think that's a better fix, maybe you can take it over?

Yes, changing the defaults seems like a better approach. Could you clarify what you mean by "take it over"? I tried updating the other revision with the changes you suggested, but you I could not find a way to do it. Phabricator only seems to allow me to change my own revisions.

It's the "Commandeer Revision" action in the "Add Action..." drop-down above the comment box.

It's the "Commandeer Revision" action in the "Add Action..." drop-down above the comment box.

Thanks!

dcederman abandoned this revision.Jun 3 2018, 11:41 PM