[MIRParser] Add parser support for 'true' and 'false' i1s.

[aemerson]

Summary

We already output true and false in the printer, but the parser isn't able to read it.

[thegameg]

lib/CodeGen/MIRParser/MIParser.cpp

1389 ↗

(On Diff #148754)

It looks like parseIRConstant already handles true and false. Can we reuse that here?

1907 ↗

(On Diff #148754)

Can we get a test for the errors here?

[rtereshin]

lib/CodeGen/MIRParser/MIParser.cpp

1389 ↗

(On Diff #148754)

Also, parseIRConstant will produce a neat error message if the boolean literal isn't specified as i1:

error: /Volumes/Data/llvm/test/CodeGen/MIR/AArch64/parse-integer-true-false.mir:9:32: constant expression type mismatch
    %0:_(s32) = G_CONSTANT i32 true

while the current version will just silently replace the type with i1.

[aemerson]

lib/CodeGen/MIRParser/MIParser.cpp

1389 ↗

(On Diff #148754)

Sure, that makes it a lot simpler.

[rtereshin]

lib/CodeGen/MIRParser/MIParser.cpp

1379 ↗

(On Diff #149467)

Why startswith instead of direct comparisons? Is it going to parse truee as true?

[aemerson]

lib/CodeGen/MIRParser/MIParser.cpp

1379 ↗

(On Diff #149467)

It won't parse that because parseIRConstant will fail, but you're right I had startswith mistakenly because it was a stringref view onto the raw source since they're not tokens any more, which in the debugger looked like a longer string than just "true" or "false".

llvm/trunk/lib/CodeGen/MIRParser/MIParser.cpp

if (TypeStr.front() != 'i' && TypeStr.front() != 's' &&
     return error(
         "a typed immediate operand should start with one of 'i', 's', or 'p'");
   StringRef SizeStr = Token.range().drop_front();
   if (SizeStr.size() == 0 || !llvm::all_of(SizeStr, isdigit))
     return error("expected integers after 'i'/'s'/'p' type character");
 
   auto Loc = Token.location();
   lex();
-  if (Token.isNot(MIToken::IntegerLiteral))
+  if (Token.isNot(MIToken::IntegerLiteral)) {
+    if (Token.isNot(MIToken::Identifier) ||
+        !(Token.range() == "true" || Token.range() == "false"))
       return error("expected an integer literal");
+  }
   const Constant *C = nullptr;
   if (parseIRConstant(Loc, C))
     return true;
   Dest = MachineOperand::CreateCImm(cast<ConstantInt>(C));
   return false;
 }
 
 bool MIParser::parseFPImmediateOperand(MachineOperand &Dest) {

llvm/trunk/test/CodeGen/MIR/Generic/parse-integer-true-false.mir

+# RUN: llc -run-pass none -o - %s | FileCheck %s
+# Parse an i1 being a 'true' or 'false'
+---
+name: i1_true_false
+body: |
+  bb.0:
+    ; CHECK: %0:_(s1) = G_CONSTANT i1 true
+    ; CHECK: %1:_(s1) = G_CONSTANT i1 false
+    %0:_(s1) = G_CONSTANT i1 true
+    %1:_(s1) = G_CONSTANT i1 false
+...