Page MenuHomePhabricator

Move SystemInitializerFull header to source/API
ClosedPublic

Authored by xiaobai on May 24 2018, 11:53 AM.

Details

Summary

It seems to me that files in include/lldb/API/ are headers that should
be exposed to liblldb users. Because SystemInitializerFull.h exposes details of
lldb_private, I think having it there is not the right thing to do. Since it's
only included from files in source/API, we should move it there and treat it as
private.

Diff Detail

Repository
rL LLVM

Event Timeline

xiaobai created this revision.May 24 2018, 11:53 AM

Looks good to me. Pavel, you ok with the file location?

labath accepted this revision.May 24 2018, 12:57 PM

Fine by me.

This revision is now accepted and ready to land.May 24 2018, 12:57 PM
clayborg accepted this revision.May 24 2018, 1:30 PM
This revision was automatically updated to reflect the committed changes.