This is an archive of the discontinued LLVM Phabricator instance.

Differential D47200

[Sema] Add tests for weak functions
ClosedPublic

Authored by Hahnfeld on May 22 2018, 8:51 AM.

Details

Reviewers
aaron.ballman
rjmccall
Commits
rG7411d61c03e8: [Sema] Add tests for weak functions
rC333283: [Sema] Add tests for weak functions
rL333283: [Sema] Add tests for weak functions
Summary

I found these checks to be missing, just add some simple cases.

Diff Detail

Repository
rL LLVM

Event Timeline

Hahnfeld created this revision.May 22 2018, 8:51 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptMay 22 2018, 8:51 AM
aaron.ballman accepted this revision.May 22 2018, 9:08 AM

LGTM!

This revision is now accepted and ready to land.May 22 2018, 9:08 AM
Closed by commit rL333283: [Sema] Add tests for weak functions (authored by Hahnfeld). · Explain WhyMay 25 2018, 9:00 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 25 2018, 9:00 AM

Revision Contents

PathSize
cfe/
trunk/
test/
Sema/
3 lines

Diff 148616

cfe/trunk/test/Sema/attr-weak.c

// RUN: %clang_cc1 -verify -fsyntax-only %s // RUN: %clang_cc1 -verify -fsyntax-only %s
extern int f0() __attribute__((weak));
extern int g0 __attribute__((weak)); extern int g0 __attribute__((weak));
extern int g1 __attribute__((weak_import)); extern int g1 __attribute__((weak_import));
int f2() __attribute__((weak));
int g2 __attribute__((weak)); int g2 __attribute__((weak));
int g3 __attribute__((weak_import)); // expected-warning {{'weak_import' attribute cannot be specified on a definition}} int g3 __attribute__((weak_import)); // expected-warning {{'weak_import' attribute cannot be specified on a definition}}
int __attribute__((weak_import)) g4(void); int __attribute__((weak_import)) g4(void);
void __attribute__((weak_import)) g5(void) { void __attribute__((weak_import)) g5(void) {
} }
struct __attribute__((weak)) s0 {}; // expected-warning {{'weak' attribute only applies to variables, functions, and classes}} struct __attribute__((weak)) s0 {}; // expected-warning {{'weak' attribute only applies to variables, functions, and classes}}
struct __attribute__((weak_import)) s1 {}; // expected-warning {{'weak_import' attribute only applies to variables and functions}} struct __attribute__((weak_import)) s1 {}; // expected-warning {{'weak_import' attribute only applies to variables and functions}}
static int f() __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}
static int x __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}} static int x __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}
// rdar://9538608 // rdar://9538608
int C; // expected-note {{previous definition is here}} int C; // expected-note {{previous definition is here}}
extern int C __attribute__((weak_import)); // expected-warning {{an already-declared variable is made a weak_import declaration}} extern int C __attribute__((weak_import)); // expected-warning {{an already-declared variable is made a weak_import declaration}}
static int pr14946_x; static int pr14946_x;
extern int pr14946_x __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}} extern int pr14946_x __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}
static void pr14946_f(); static void pr14946_f();
void pr14946_f() __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}} void pr14946_f() __attribute__((weak)); // expected-error {{weak declaration cannot have internal linkage}}