This is an archive of the discontinued LLVM Phabricator instance.

Paths

[LNT] Sort machines in Compare to by names.
ClosedPublic

Authored by marxin on May 22 2018, 1:39 AM.

Reviewers

Commits

rL333260: Sort machines in Compare to by names.

Summary

I consider it's easier to find a machine to compare with.

LGTM

This revision is now accepted and ready to land.May 22 2018, 1:55 PM

Why not let the database do the sorting? .order_by(ts.Machine.name) or whatever sqlalchemy wants there?

Updated version that I'm going to install.

This revision was automatically updated to reflect the committed changes.

Path

Size

lnt/

server/

ui/

2 lines

Show First 20 Lines • Show All 318 Lines • ▼ Show 20 Lines	if request.args.get('json'):
for order in associated_runs:		for order in associated_runs:
rev = order[0].llvm_project_revision		rev = order[0].llvm_project_revision
for run in order[1]:		for run in order[1]:
json_obj['runs'].append((run.id, rev,		json_obj['runs'].append((run.id, rev,
run.start_time.isoformat(),		run.start_time.isoformat(),
run.end_time.isoformat()))		run.end_time.isoformat()))
return flask.jsonify(**json_obj)		return flask.jsonify(**json_obj)

machines = session.query(ts.Machine).all()		machines = session.query(ts.Machine).order_by(ts.Machine.name).all()
relatives = [m for m in machines if m.name == machine.name]		relatives = [m for m in machines if m.name == machine.name]
return render_template("v4_machine.html",		return render_template("v4_machine.html",
testsuite_name=g.testsuite_name,		testsuite_name=g.testsuite_name,
id=id,		id=id,
associated_runs=associated_runs,		associated_runs=associated_runs,
machine=machine,		machine=machine,
machines=machines,		machines=machines,
relatives=relatives,		relatives=relatives,
▲ Show 20 Lines • Show All 1,557 Lines • Show Last 20 Lines