This removes 6 intrinsics since we no longer need separate mask and maskz intrinsics.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 18400 Build 18400: arc lint + arc unit
Event Timeline
Comment Actions
I don't know that the fast-isel tests would show anything more than the intrinsics tests do since I ran those test cases through the autoupgrade code to get IR with selects. Should I move the intrinsic+select to fast-isel and leave just intrinsic by itself in the *intrinsic.ll test?
Comment Actions
If you want to be completely thorough then test -fast-isel with the code from D47125 - the intrinsics tests are more about coverage and checking all intrinsic variants (masks, load folding etc,.).
IMO it's not a critical issue - although teams are oddly sensitive about debug code not using the intrinsics they expect......
Is it worth pulling out the CI->getType() repetitions?