Removed analysis flag from SafepointIRVerifier pass

[yrouban]

Summary

Removed analysis flag from the SafepointIRVerifier pass.

[yrouban]

Please take a look.

[fedor.sergeev]

Can you, please, describe the reason for this change?

[yrouban]

This change is needed to freely add this pass using schedulePass() at any place in pipeline (even more than once at the same place). Analysis passes can be deleted by this call (see PMTopLevelManager::schedulePass()) and this can be misleading for developers who want expect the pass be inserted exactly at the play they need. There is no easy way to know if the pass is added or deleted. Essentially, SafepointIRVerifier is not intended to be an analysis pass.
Look at the other verification passes. They all are not analysis. Except the SafepointMachineVerifier which probably is the source of this mistake.

[yrouban]

the landed patch D47441 supersedes this one.

lib/IR/SafepointIRVerifier.cpp

 
 char SafepointIRVerifier::ID = 0;
 
 FunctionPass *llvm::createSafepointIRVerifierPass() {
   return new SafepointIRVerifier();
 }
 
 INITIALIZE_PASS_BEGIN(SafepointIRVerifier, "verify-safepoint-ir",
-                      "Safepoint IR Verifier", false, true)
+                      "Safepoint IR Verifier", false, false)
 INITIALIZE_PASS_END(SafepointIRVerifier, "verify-safepoint-ir",
-                    "Safepoint IR Verifier", false, true)
+                    "Safepoint IR Verifier", false, false)
 
 static bool isGCPointerType(Type *T) {
   if (auto *PT = dyn_cast<PointerType>(T))
     // For the sake of this example GC, we arbitrarily pick addrspace(1) as our
     // GC managed heap.  We know that a pointer into this heap needs to be
     // updated and that no other pointer does.
     return (1 == PT->getAddressSpace());
   return false;