This is an archive of the discontinued LLVM Phabricator instance.

Differential D46991

[CMake] Support building shared library for Fuchsia
ClosedPublic

Authored by phosek on May 16 2018, 5:06 PM.

Details

Reviewers
mcgrathr
jakehehrlich
Commits
rGdfbb9416695e: [CMake] Support building shared library for Fuchsia
rL332570: [CMake] Support building shared library for Fuchsia
Summary

Fuchsia uses ELF as a file format and LLD as the linker so we can
use the same implementation as other ELF based platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.May 16 2018, 5:06 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptMay 16 2018, 5:06 PM
jakehehrlich accepted this revision.May 16 2018, 5:18 PM
This revision is now accepted and ready to land.May 16 2018, 5:18 PM
Closed by commit rL332570: [CMake] Support building shared library for Fuchsia (authored by phosek). · Explain WhyMay 16 2018, 8:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
tools/
llvm-shlib/
1 line

Diff 147232

llvm/trunk/tools/llvm-shlib/CMakeLists.txt

Show All 33 Linesif(LLVM_DYLIB_EXPORTED_SYMBOL_FILE)
add_custom_target(libLLVMExports DEPENDS ${LLVM_EXPORTED_SYMBOL_FILE}) add_custom_target(libLLVMExports DEPENDS ${LLVM_EXPORTED_SYMBOL_FILE})
endif() endif()
add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB SONAME ${SOURCES}) add_llvm_library(LLVM SHARED DISABLE_LLVM_LINK_LLVM_DYLIB SONAME ${SOURCES})
list(REMOVE_DUPLICATES LIB_NAMES) list(REMOVE_DUPLICATES LIB_NAMES)
if(("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") OR (MINGW) OR (HAIKU) if(("${CMAKE_SYSTEM_NAME}" STREQUAL "Linux") OR (MINGW) OR (HAIKU)
OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD") OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "FreeBSD")
OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "Fuchsia")
OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "DragonFly") OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "DragonFly")
OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "SunOS")) # FIXME: It should be "GNU ld for elf" OR ("${CMAKE_SYSTEM_NAME}" STREQUAL "SunOS")) # FIXME: It should be "GNU ld for elf"
configure_file( configure_file(
${CMAKE_CURRENT_SOURCE_DIR}/simple_version_script.map.in ${CMAKE_CURRENT_SOURCE_DIR}/simple_version_script.map.in
${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map) ${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map)
# GNU ld doesn't resolve symbols in the version script. # GNU ld doesn't resolve symbols in the version script.
set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive) set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines