This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis] Add a flag to output analysis csv to a file.
ClosedPublic

Authored by courbet on May 16 2018, 2:03 AM.

Download Raw Diff

Details

Reviewers

Commits

rGcaa163ef6a75: [llvm-exegesis] Add a flag to output analysis csv to a file.
rL332445: [llvm-exegesis] Add a flag to output analysis csv to a file.

Diff Detail

Repository

rL LLVM

Build Status

Buildable 18166
Build 18166: arc lint + arc unit

Event Timeline

courbet created this revision.May 16 2018, 2:03 AM

Herald added a subscriber: tschuett. · View Herald TranscriptMay 16 2018, 2:03 AM

gchatelet requested changes to this revision.May 16 2018, 2:15 AM

gchatelet added inline comments.

tools/llvm-exegesis/llvm-exegesis.cpp
142	Remove the line.
159	Does this work with "-" ?

This revision now requires changes to proceed.May 16 2018, 2:15 AM

address review comments

tools/llvm-exegesis/llvm-exegesis.cpp
159	Sure.

gchatelet accepted this revision.May 16 2018, 2:53 AM

This revision is now accepted and ready to land.May 16 2018, 2:53 AM

Closed by commit rL332445: [llvm-exegesis] Add a flag to output analysis csv to a file. (authored by courbet). · Explain WhyMay 16 2018, 2:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

tools/

llvm-exegesis/

llvm-exegesis.cpp

14 lines

Diff 147015

tools/llvm-exegesis/llvm-exegesis.cpp

Show First 20 Lines • Show All 64 Lines • ▼ Show 20 Lines	static llvm::cl::opt<unsigned> AnalysisNumPoints(
llvm::cl::desc("minimum number of points in an analysis cluster"),		llvm::cl::desc("minimum number of points in an analysis cluster"),
llvm::cl::init(3));		llvm::cl::init(3));

static llvm::cl::opt<float>		static llvm::cl::opt<float>
AnalysisEpsilon("analysis-epsilon",		AnalysisEpsilon("analysis-epsilon",
llvm::cl::desc("dbscan epsilon for analysis clustering"),		llvm::cl::desc("dbscan epsilon for analysis clustering"),
llvm::cl::init(0.1));		llvm::cl::init(0.1));

		static llvm::cl::opt<std::string> AnalysisClustersFile("analysis-clusters-file",
		llvm::cl::desc(""),
		llvm::cl::init("-"));

namespace exegesis {		namespace exegesis {

void benchmarkMain() {		void benchmarkMain() {
if (exegesis::pfm::pfmInitialize())		if (exegesis::pfm::pfmInitialize())
llvm::report_fatal_error("cannot initialize libpfm");		llvm::report_fatal_error("cannot initialize libpfm");

if (OpcodeName.empty() == (OpcodeIndex == 0))		if (OpcodeName.empty() == (OpcodeIndex == 0))
llvm::report_fatal_error(		llvm::report_fatal_error(
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines	void analysisMain() {
llvm::outs() << "Parsed " << Points.size() << " benchmark points\n";		llvm::outs() << "Parsed " << Points.size() << " benchmark points\n";
if (Points.empty()) {		if (Points.empty()) {
llvm::errs() << "no benchmarks to analyze\n";		llvm::errs() << "no benchmarks to analyze\n";
return;		return;
}		}
// FIXME: Check that all points have the same triple/cpu.		// FIXME: Check that all points have the same triple/cpu.
// FIXME: Merge points from several runs (latency and uops).		// FIXME: Merge points from several runs (latency and uops).

//llvm::InitializeAllTargets();		// llvm::InitializeAllTargets();
		gchateletUnsubmitted Done Reply Inline Actions Remove the line. gchatelet: Remove the line.
llvm::InitializeNativeTarget();		llvm::InitializeNativeTarget();
llvm::InitializeNativeTargetAsmPrinter();		llvm::InitializeNativeTargetAsmPrinter();

std::string Error;		std::string Error;
const auto *TheTarget =		const auto *TheTarget =
llvm::TargetRegistry::lookupTarget(Points[0].LLVMTriple, Error);		llvm::TargetRegistry::lookupTarget(Points[0].LLVMTriple, Error);
if (!TheTarget) {		if (!TheTarget) {
llvm::errs() << "unknown target '" << Points[0].LLVMTriple << "'\n";		llvm::errs() << "unknown target '" << Points[0].LLVMTriple << "'\n";
return;		return;
}		}
const auto Clustering = llvm::cantFail(InstructionBenchmarkClustering::create(		const auto Clustering = llvm::cantFail(InstructionBenchmarkClustering::create(
Points, AnalysisNumPoints, AnalysisEpsilon));		Points, AnalysisNumPoints, AnalysisEpsilon));

const Analysis Analyzer(*TheTarget, Clustering);		const Analysis Analyzer(*TheTarget, Clustering);

if (auto Err = Analyzer.printClusters(llvm::outs()))		std::error_code ErrorCode;
		llvm::raw_fd_ostream ClustersOS(AnalysisClustersFile, ErrorCode,
		gchateletUnsubmitted Not Done Reply Inline Actions Does this work with "-" ? gchatelet: Does this work with "-" ?
		courbetAuthorUnsubmitted Not Done Reply Inline Actions Sure. courbet: Sure.
		llvm::sys::fs::F_RW);
		if (ErrorCode)
		llvm::report_fatal_error("cannot open out file: " + AnalysisClustersFile);

		if (auto Err = Analyzer.printClusters(ClustersOS))
llvm::report_fatal_error(std::move(Err));		llvm::report_fatal_error(std::move(Err));
}		}

} // namespace exegesis		} // namespace exegesis

int main(int Argc, char **Argv) {		int main(int Argc, char **Argv) {
llvm::cl::ParseCommandLineOptions(Argc, Argv, "");		llvm::cl::ParseCommandLineOptions(Argc, Argv, "");

if (BenchmarkMode == BenchmarkModeE::Analysis) {		if (BenchmarkMode == BenchmarkModeE::Analysis) {
exegesis::analysisMain();		exegesis::analysisMain();
} else {		} else {
exegesis::benchmarkMain();		exegesis::benchmarkMain();
}		}
return EXIT_SUCCESS;		return EXIT_SUCCESS;
}		}