Added InstCombine transform for pattern "(A ^ B) | ((~A) ^ B) -> True".

[sonamkumari]

Summary

This patch implements transform for pattern "(A ^ B) | ((~A) ^ B) -> True".

Please help in reviewing the same.

Thanks,
Sonam.

[majnemer]

lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

1283

This change seems irrelevant to the patch.

1986–1989

See my comments in your other differential, D4690.

test/Transforms/InstCombine/or.ll

411–420

Again, please see my comments in D4690.

[sonamkumari]

Hi David,

Thanks for your valuable review comments.
I have made the changes as you mentioned.
Please help in reviewing the patch.

Thanks,
Sonam.

[majnemer]

Thinking about this with some colleagues, I'm starting to believe that this can be fixed in a more general way.

We do not optimize (A ^ B) | ((A ^ -1) ^ B) but we correctly optimize (A ^ B) | ((A ^ B) ^ -1); this makes me think that we are looking at a bug in reassociate.

lib/Analysis/InstructionSimplify.cpp

1606 ↗

(On Diff #12015)

This comment looks wrong, it should probably be:

// (A ^ B) | ((~A) ^ B) = -1

[majnemer]

I've gone ahead and fixed this in rL214342; it includes a more general transform which should handle more cases.

[sonamkumari]

Hi David,

Thanks for your valuable comments.I will try to consider general case while doing any optimization in future.
But the patch which you uploaded in rL214342 fails for the following test cases as it doesn't take into consideration the symmetric case.

The test cases for which it fails are :

define i32 @test14(i32 %x, i32 %y) {

%nega = xor i32 %x, -1
%xor = xor i32 %nega, %y
%xor1 = xor i32 %x, %y
%or = or i32 %xor, %xor1
ret i32 %or

}

define i32 @test15(i32 %x, i32 %y) {

%xor = xor i32 %x, %y
%nega = xor i32 %x, -1
%xor1 = xor i32 %nega, %y
%or = or i32 %xor, %xor1
ret i32 %or

}

So, I modified the patch and submitting the same.
Kindly review it.

Thanks,
Sonam.

[suyog]

LGTM. I would wait for David to comment on it though.

[majnemer]

I don't think we need to do anything here, running reassociate before instcombine cleans things up.

$ cat t.ll
define i32 @test14(i32 %x, i32 %y) {
  %nega = xor i32 %x, -1
  %xor = xor i32 %nega, %y
  %xor1 = xor i32 %x, %y
  %or = or i32 %xor, %xor1
  ret i32 %or
}

define i32 @test15(i32 %x, i32 %y) {
  %xor = xor i32 %x, %y
  %nega = xor i32 %x, -1
  %xor1 = xor i32 %nega, %y
  %or = or i32 %xor, %xor1
  ret i32 %or
}

$ ~/llvm/Debug+Asserts/bin/opt -reassociate -instcombine t.ll -o - -S
; ModuleID = 't.ll'

define i32 @test14(i32 %x, i32 %y) {
  ret i32 -1
}

define i32 @test15(i32 %x, i32 %y) {
  ret i32 -1
}

lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

if (Value *Op0NotVal = dyn_castNotVal(Op0))
     }
 
     // (A&((~A)|B)) -> A&B
     if (match(Op0, m_Or(m_Not(m_Specific(Op1)), m_Value(A))) ||
         match(Op0, m_Or(m_Value(A), m_Not(m_Specific(Op1)))))
       return BinaryOperator::CreateAnd(A, Op1);
     if (match(Op1, m_Or(m_Not(m_Specific(Op0)), m_Value(A))) ||
         match(Op1, m_Or(m_Value(A), m_Not(m_Specific(Op0)))))
         return BinaryOperator::CreateAnd(A, Op0);
+
   }
 
   if (ICmpInst *RHS = dyn_cast<ICmpInst>(Op1))
     if (ICmpInst *LHS = dyn_cast<ICmpInst>(Op0))
       if (Value *Res = FoldAndOfICmps(LHS, RHS))
         return ReplaceInstUsesWith(I, Res);
 
   // If and'ing two fcmp, try combine them into one.
Instruction *InstCombiner::visitOr(BinaryOperator &I) {
   if (Op1->hasOneUse() &&
       match(Op1, m_Xor(m_Value(A), m_ConstantInt(C1))) &&
       MaskedValueIsZero(Op0, C1->getValue())) {
     Value *NOr = Builder->CreateOr(A, Op0);
     NOr->takeName(Op0);
     return BinaryOperator::CreateXor(NOr, C1);
   }
 
+  // (A^B) | (~(A)^B) -> 1
+    if(match(Op0,m_Xor(m_Value(A),m_Value(B)))
+            && match(Op1,m_Xor(m_Not(m_Specific(A)),m_Specific(B))))
+        return BinaryOperator::CreateOr(A, Builder->CreateNot(A));
+
   // (A & C)|(B & D)
   Value *C = nullptr, *D = nullptr;
   if (match(Op0, m_And(m_Value(A), m_Value(C))) &&
       match(Op1, m_And(m_Value(B), m_Value(D)))) {
     Value *V1 = nullptr, *V2 = nullptr;
     C1 = dyn_cast<ConstantInt>(C);
     C2 = dyn_cast<ConstantInt>(D);
     if (C1 && C2) {  // (A & C1)|(B & C2)

test/Transforms/InstCombine/or.ll

 ; CHECK-LABEL: @test38(
 ; CHECK: select i1 %tobool, i32 -1, i32 %x
   %tobool = icmp ne i32 %y, 0
   %sext = sext i1 %tobool to i32
   %x = load i32* %xp
   %or = or i32 %x, %sext
   ret i32 %or
 }
+
+define i32 @test39(i32%x,i32%y){
+; CHECK-LABEL: @test39(
+; CHECK-NEXT: ret i32 -1
+%xor = xor i32%x,%y
+%nega = xor i32%x,-1
+%xor1 = xor i32%nega,%y
+%or = or i32%xor,%xor1
+ret i32 %or
+}