Page MenuHomePhabricator
People suyog

suyog (suyog)
User

Projects

User does not belong to any projects.

User Details

User Since
May 14 2014, 5:16 AM (362 w, 12 h)

Recent Activity
View All

Dec 14 2015

suyog added a comment to D6818: [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4).

@nadav : I abandoned this revision. Did i do anything wrong which triggered something else?

Dec 14 2015, 9:08 AM
suyog abandoned D6818: [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4).
Dec 14 2015, 8:17 AM
suyog added inline comments to D15250: Detecte vector reduction operations just before instruction selection..
Dec 14 2015, 12:15 AM

Mar 30 2015

suyog abandoned D8629: [RFC] Patch for Bug 18808 - clang -O3 -flto drops Target feature flags.

Thanks Eric for pointing out the CL's.

Mar 30 2015, 11:36 AM
suyog added a comment to D8629: [RFC] Patch for Bug 18808 - clang -O3 -flto drops Target feature flags.

Hi David, Eric,

Mar 30 2015, 3:54 AM

Mar 26 2015

suyog resigned from D4828: Added InstCombine transform for pattern "(A & B) ^ ((A ^ C) | B) -> (~A)"..
Mar 26 2015, 12:00 PM
suyog retitled D8629: [RFC] Patch for Bug 18808 - clang -O3 -flto drops Target feature flags from to [RFC] Patch for Bug 18808 - clang -O3 -flto drops Target feature flags.
Mar 26 2015, 3:41 AM

Jan 9 2015

suyog committed rL225517: Assumption that "VectorizedValue" will always be an Instruction is not correct..
Assumption that "VectorizedValue" will always be an Instruction is not correct.
Jan 9 2015, 2:25 AM

Jan 8 2015

suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael,

Jan 8 2015, 12:18 PM

Jan 5 2015

suyog added a comment to D6818: [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4).

Hi James,

Jan 5 2015, 4:24 AM

Jan 1 2015

suyog updated the diff for D6818: [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4).

Hi Charlie,

Jan 1 2015, 11:58 PM

Dec 31 2014

suyog retitled D6818: [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4) from to [SLPVectorization] Vectorize flat addition in a single tree (+(+(+ v1 v2) v3) v4).
Dec 31 2014, 2:53 AM

Dec 25 2014

suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael.

Dec 25 2014, 10:13 PM

Dec 23 2014

suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael,

Dec 23 2014, 6:03 AM

Dec 22 2014

suyog updated the diff for D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael,

Dec 22 2014, 12:00 AM

Dec 21 2014

suyog updated the diff for D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael,

Dec 21 2014, 9:39 PM
suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi Michael,

Dec 21 2014, 9:49 AM

Dec 17 2014

suyog updated the diff for D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Reverted 224119 because floating point data types cannot be freely re-associated unless ffast-math specified.

Dec 17 2014, 4:09 AM
suyog committed rL224424: Revert 224119 "This patch recognizes (+ (+ v0, v1) (+ v2, v3)), reorders them….
Revert 224119 "This patch recognizes (+ (+ v0, v1) (+ v2, v3)), reorders them…
Dec 17 2014, 2:35 AM

Dec 16 2014

suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi James,

Dec 16 2014, 12:58 AM
suyog added a comment to D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .

Hi James,

Dec 16 2014, 12:00 AM

Dec 15 2014

suyog retitled D6675: [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads from to [SLPVectorization] Enhance Ability to Vectorize Horizontal Reductions from Consecutive Loads .
Dec 15 2014, 9:22 PM
suyog committed rL224244: Typo Correction in Test Case. NFC..
Typo Correction in Test Case. NFC.
Dec 15 2014, 4:20 AM

Dec 12 2014

suyog committed rL224119: This patch recognizes (+ (+ v0, v1) (+ v2, v3)), reorders them for bundling….
This patch recognizes (+ (+ v0, v1) (+ v2, v3)), reorders them for bundling…
Dec 12 2014, 4:54 AM

Dec 9 2014

suyog accepted D6380: Removal Of Duplicate Test Cases and Addition of Check Statements.

LGTM

Dec 9 2014, 2:27 AM
suyog accepted D6475: [test/Transforms/InstCombine/shift.ll] Removed duplicate test cases.

LGTM

Dec 9 2014, 2:23 AM

Nov 27 2014

suyog closed D6430: [and-compare.ll] [and-xor-merge.ll] Added Check Statements for test cases.

Closed by commit rL222879 (authored by @suyog).

Nov 27 2014, 3:23 AM
suyog closed D6432: Added Check Statements for "not.ll & not-fcmp.ll" files..

Closed by commit rL222876 (authored by @suyog).

Nov 27 2014, 2:57 AM
suyog accepted D6432: Added Check Statements for "not.ll & not-fcmp.ll" files..

LGTM

Nov 27 2014, 1:54 AM
suyog accepted D6430: [and-compare.ll] [and-xor-merge.ll] Added Check Statements for test cases.

LGTM

Nov 27 2014, 12:51 AM
suyog requested changes to D6429: Added Missing Check Statements for "apint-select.ll" file..

There is already CHECK-NOT present which checks if select is eliminated or not.
The objective of this test case was to check if select is eliminated.

Nov 27 2014, 12:19 AM

Nov 25 2014

suyog closed D6382: [xor.ll] Added Missing Check Statements for test cases.

Closed by commit rL222740 (authored by @suyog).

Nov 25 2014, 12:45 AM
suyog accepted D6382: [xor.ll] Added Missing Check Statements for test cases.

Looks fine now

Nov 25 2014, 12:39 AM

Nov 24 2014

suyog added a comment to D6382: [xor.ll] Added Missing Check Statements for test cases.

Hi Ankur,

Nov 24 2014, 2:12 AM

Nov 19 2014

suyog closed D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.

Closed by commit rL222364 (authored by @suyog).

Nov 19 2014, 8:07 AM
suyog accepted D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.
Nov 19 2014, 6:07 AM

Nov 18 2014

suyog added a comment to D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.

Gentle Ping !!

Nov 18 2014, 5:05 AM

Nov 14 2014

suyog added a comment to D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.

Hi all,

Nov 14 2014, 4:27 AM

Nov 12 2014

suyog updated the diff for D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.

Hi Hal, Arnold, James,

Nov 12 2014, 9:10 AM
suyog retitled D6227: [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement from to [SLPVectorization] Vectorize Reduction Chain feeding into a 'return' statement.
Nov 12 2014, 8:11 AM

Nov 10 2014

suyog added a comment to D6181: [AArch64] LoopVectorizer test case for cost model to handle signed division by a power of 2.

Thanks Chad. committed in r221674 with space as per your review.

Nov 10 2014, 11:34 PM
suyog closed D6181: [AArch64] LoopVectorizer test case for cost model to handle signed division by a power of 2.

Closed by commit rL221674 (authored by @suyog).

Nov 10 2014, 11:30 PM

Nov 8 2014

suyog retitled D6181: [AArch64] LoopVectorizer test case for cost model to handle signed division by a power of 2 from to [AArch64] LoopVectorizer test case for cost model to handle signed division by a power of 2.
Nov 8 2014, 1:42 AM

Oct 9 2014

suyog added a comment to D5700: [InstCombine] Fix wrong folding of constant comparisons involving ashr and negative values (PR21222)..

Hi Andrea,

Oct 9 2014, 5:12 AM

Oct 8 2014

suyog added a comment to D5649: [InstCombineAddSub.cpp] Corrected Formatting and Indentation.

committed in r219286.
Thanks !

Oct 8 2014, 1:50 AM
suyog accepted D5649: [InstCombineAddSub.cpp] Corrected Formatting and Indentation.

LGTM

Oct 8 2014, 1:40 AM

Oct 7 2014

suyog added a comment to D5649: [InstCombineAddSub.cpp] Corrected Formatting and Indentation.

Few comments inline.
I would suggest to re-direct it to someone who is more familiar with clang-format.

Oct 7 2014, 11:41 PM
suyog closed D5644: Indentation Correction.

Closed by commit rL219203 (authored by @suyog).

Oct 7 2014, 5:14 AM
suyog accepted D5644: Indentation Correction.

LGTM.

Oct 7 2014, 5:13 AM
suyog added a comment to D5645: Indentation Correction.

LGTM. committed in r219202.
Thanks !

Oct 7 2014, 5:08 AM
suyog closed D5645: Indentation Correction.

Closed by commit rL219202 (authored by @suyog).

Oct 7 2014, 5:06 AM
suyog accepted D5647: [icmp-shr.ll] Removed extra white space.

LGTM. committed in r219201.

Oct 7 2014, 4:42 AM

Sep 15 2014

suyog added a comment to D5356: InstCombine: constant comparison involving ashr is wrongly simplified (PR20945)..

Hi Andrea,

Sep 15 2014, 11:31 PM

Aug 19 2014

suyog added a comment to D4970: Added InstCombine Transformation for (A|B)^((A^C)|B) --> (~B)C.

Please run clang format before submitting any patch.

Aug 19 2014, 2:31 AM

Aug 8 2014

suyog added a comment to D4828: Added InstCombine transform for pattern "(A & B) ^ ((A ^ C) | B) -> (~A)"..

Hi Sonam,

Aug 8 2014, 10:48 AM

Aug 7 2014

suyog added a comment to D4690: Added InstCombine transform for pattern "(A ^ B) & ((~A) ^ B) -> False".

LGTM. I would wait for David to comment on it though.

Aug 7 2014, 4:42 AM
suyog added a reviewer for D4690: Added InstCombine transform for pattern "(A ^ B) & ((~A) ^ B) -> False": suyog.
Aug 7 2014, 4:41 AM
suyog added a comment to D4691: Added InstCombine transform for pattern "(A ^ B) | ((~A) ^ B) -> True"..

LGTM. I would wait for David to comment on it though.

Aug 7 2014, 4:40 AM
suyog added a reviewer for D4691: Added InstCombine transform for pattern "(A ^ B) | ((~A) ^ B) -> True".: suyog.
Aug 7 2014, 4:38 AM

Jul 31 2014

suyog closed D4653: Added InstCombine transform for pattern "(A & ~B) ^ (~A) -> ~(A & B)".

Closed by commit rL214479 (authored by @suyog).

Jul 31 2014, 10:16 PM
suyog closed D4628: Added InstCombine transform for pattern "(A | B) & ((~A) ^ B) -> (A & B)" .

Closed by commit rL214478 (authored by @suyog).

Jul 31 2014, 10:08 PM
suyog closed D4652: Added InstCombine transform for pattern "( A & (~B)) | (A ^ B) -> (A ^ B)".

Closed by commit rL214477 (authored by @suyog).

Jul 31 2014, 9:59 PM
suyog closed D4655: Added InstCombine transform for pattern "(A & B) | ((~A) ^ B) -> (~A ^ B)".

Closed by commit rL214476 (authored by @suyog).

Jul 31 2014, 9:51 PM
suyog added a comment to D4628: Added InstCombine transform for pattern "(A | B) & ((~A) ^ B) -> (A & B)" .

Gentle Ping !!

Jul 31 2014, 10:39 AM
suyog added a comment to D4652: Added InstCombine transform for pattern "( A & (~B)) | (A ^ B) -> (A ^ B)".

Gentle Ping !!

Jul 31 2014, 10:38 AM
suyog added a comment to D4653: Added InstCombine transform for pattern "(A & ~B) ^ (~A) -> ~(A & B)".

Gentle Ping !!

Jul 31 2014, 10:38 AM
suyog added a comment to D4655: Added InstCombine transform for pattern "(A & B) | ((~A) ^ B) -> (~A ^ B)".

Gentle Ping !!

Jul 31 2014, 10:37 AM

Jul 24 2014

suyog retitled D4655: Added InstCombine transform for pattern "(A & B) | ((~A) ^ B) -> (~A ^ B)" from to Added InstCombine transform for pattern "(A & B) | ((~A) ^ B) -> (~A ^ B)".
Jul 24 2014, 6:04 AM
suyog retitled D4653: Added InstCombine transform for pattern "(A & ~B) ^ (~A) -> ~(A & B)" from to Added InstCombine transform for pattern "(A & ~B) ^ (~A) -> ~(A & B)".
Jul 24 2014, 4:57 AM
suyog retitled D4652: Added InstCombine transform for pattern "( A & (~B)) | (A ^ B) -> (A ^ B)" from to Added InstCombine transform for pattern "( A & (~B)) | (A ^ B) -> (A ^ B)".
Jul 24 2014, 3:49 AM

Jul 22 2014

suyog retitled D4628: Added InstCombine transform for pattern "(A | B) & ((~A) ^ B) -> (A & B)" from to Added InstCombine transform for pattern "(A | B) & ((~A) ^ B) -> (A & B)" .
Jul 22 2014, 1:43 PM
suyog closed D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Closed by commit rL213678 (authored by @suyog).

Jul 22 2014, 12:28 PM
suyog accepted D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Accepting this as per review in
http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/191371

Jul 22 2014, 12:21 PM
suyog closed D4618: Added InstCombine transform for pattern "(A & B) ^ (A ^ B) -> (A | B)".

Closed by commit rL213677 (authored by @suyog).

Jul 22 2014, 11:39 AM
suyog accepted D4618: Added InstCombine transform for pattern "(A & B) ^ (A ^ B) -> (A | B)".

Accepting revision as per review :

Jul 22 2014, 11:27 AM
suyog closed D4591: Added InstCombine Transform for pattern "((~A & B) | A) -> (A | B)".

Closed by commit rL213676 (authored by @suyog).

Jul 22 2014, 11:18 AM
suyog accepted D4591: Added InstCombine Transform for pattern "((~A & B) | A) -> (A | B)".
Jul 22 2014, 11:15 AM
suyog updated the diff for D4591: Added InstCombine Transform for pattern "((~A & B) | A) -> (A | B)".

Hi Duncan,

Jul 22 2014, 10:44 AM
suyog closed D4588: Added InstCombine transform for pattern "(A | B) ^ (~A) = (~A) ^ (A | B) -> (A | ~B)".

Closed by commit rL213662 (authored by @suyog).

Jul 22 2014, 8:46 AM
suyog accepted D4588: Added InstCombine transform for pattern "(A | B) ^ (~A) = (~A) ^ (A | B) -> (A | ~B)".

Accepting revision as per reviewed in:

Jul 22 2014, 8:43 AM
suyog updated the diff for D4588: Added InstCombine transform for pattern "(A | B) ^ (~A) = (~A) ^ (A | B) -> (A | ~B)".

Made minor change in comment as suggested by Duncan in :

Jul 22 2014, 8:42 AM
suyog retitled D4618: Added InstCombine transform for pattern "(A & B) ^ (A ^ B) -> (A | B)" from to Added InstCombine transform for pattern "(A & B) ^ (A ^ B) -> (A | B)".
Jul 22 2014, 6:22 AM

Jul 18 2014

suyog retitled D4591: Added InstCombine Transform for pattern "((~A & B) | A) -> (A | B)" from to Added InstCombine Transform for pattern "((~A & B) | A) -> (A | B)".
Jul 18 2014, 12:59 PM
suyog retitled D4588: Added InstCombine transform for pattern "(A | B) ^ (~A) = (~A) ^ (A | B) -> (A | ~B)" from to Added InstCombine transform for pattern "(A | B) ^ (~A) = (~A) ^ (A | B) -> (A | ~B)".
Jul 18 2014, 12:15 PM
suyog abandoned D4585: Added InstCombine Transform for pattern "(A | B)^(~A) = (~A)^(A | B) -> (A | ~B)".
Jul 18 2014, 12:11 PM
suyog updated D4585: Added InstCombine Transform for pattern "(A | B)^(~A) = (~A)^(A | B) -> (A | ~B)".
Jul 18 2014, 12:03 PM
suyog retitled D4585: Added InstCombine Transform for pattern "(A | B)^(~A) = (~A)^(A | B) -> (A | ~B)" from to Added InstCombine Transform for pattern "(A | B)^(~A) = (~A)^(A | B) -> (A | ~B)".
Jul 18 2014, 12:02 PM

Jul 17 2014

suyog updated the diff for D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Hi Duncan, Nick

Jul 17 2014, 1:26 PM

Jul 16 2014

suyog closed D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify.

Closed by commit rL213231 (authored by @suyog).

Jul 16 2014, 11:37 PM

Jul 14 2014

suyog added a comment to D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify.

Gentle Ping !!

Jul 14 2014, 3:23 AM

Jul 13 2014

suyog updated the diff for D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Hi Duncan,

Jul 13 2014, 10:08 AM

Jul 11 2014

suyog updated the diff for D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Hi Duncan,

Jul 11 2014, 1:24 PM

Jul 9 2014

suyog updated the diff for D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Hi Duncan,

Jul 9 2014, 1:25 PM

Jul 7 2014

suyog added a comment to D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify.

Gentle Ping !!

Jul 7 2014, 11:39 AM
suyog updated the diff for D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Hi Duncan, Nick, Rafael, Sanjay,

Jul 7 2014, 11:37 AM

Jul 1 2014

suyog added a comment to D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Gentle Ping !!

Jul 1 2014, 6:34 AM

Jun 29 2014

suyog updated the diff for D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify.

Small correction.

Jun 29 2014, 9:04 PM

Jun 27 2014

suyog added a reviewer for D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify: rahuljain_1989.
Jun 27 2014, 7:52 AM
suyog updated the diff for D4102: [InstCombine/InstSimplify] Move ashr optimization from Instcombine to Instsimplify.

Hi Nick,

Jun 27 2014, 5:31 AM

Jun 24 2014

suyog added a comment to D4068: PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine).

Gentle Ping !!

Jun 24 2014, 9:38 AM