This is an archive of the discontinued LLVM Phabricator instance.

Differential D46872

[LLD] [MinGW] Handle the GNU ld option -Map for outputting a linker map
ClosedPublic

Authored by mstorsjo on May 15 2018, 5:07 AM.

Details

Reviewers
ruiu
rnk
Commits
rG036615550025: [MinGW] Handle the GNU ld option -Map for outputting a linker map
rL332398: [MinGW] Handle the GNU ld option -Map for outputting a linker map
rLLD332398: [MinGW] Handle the GNU ld option -Map for outputting a linker map

Diff Detail

Event Timeline

mstorsjo created this revision.May 15 2018, 5:07 AM
ruiu accepted this revision.May 15 2018, 1:45 PM

LGTM

This revision is now accepted and ready to land.May 15 2018, 1:45 PM
Closed by commit rLLD332398: [MinGW] Handle the GNU ld option -Map for outputting a linker map (authored by mstorsjo). · Explain WhyMay 15 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
MinGW/
2 lines
2 lines
test/
MinGW/
6 lines

Diff 146790

MinGW/Driver.cpp

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Linesbool mingw::link(ArrayRef<const char *> ArgsArr, raw_ostream &Diag) {
if (auto *A = Args.getLastArg(OPT_out_implib)) if (auto *A = Args.getLastArg(OPT_out_implib))
Add("-implib:" + StringRef(A->getValue())); Add("-implib:" + StringRef(A->getValue()));
if (auto *A = Args.getLastArg(OPT_stack)) if (auto *A = Args.getLastArg(OPT_stack))
Add("-stack:" + StringRef(A->getValue())); Add("-stack:" + StringRef(A->getValue()));
if (auto *A = Args.getLastArg(OPT_output_def)) if (auto *A = Args.getLastArg(OPT_output_def))
Add("-output-def:" + StringRef(A->getValue())); Add("-output-def:" + StringRef(A->getValue()));
if (auto *A = Args.getLastArg(OPT_image_base)) if (auto *A = Args.getLastArg(OPT_image_base))
Add("-base:" + StringRef(A->getValue())); Add("-base:" + StringRef(A->getValue()));
if (auto *A = Args.getLastArg(OPT_map))
Add("-lldmap:" + StringRef(A->getValue()));
if (auto *A = Args.getLastArg(OPT_o)) if (auto *A = Args.getLastArg(OPT_o))
Add("-out:" + StringRef(A->getValue())); Add("-out:" + StringRef(A->getValue()));
else if (Args.hasArg(OPT_shared)) else if (Args.hasArg(OPT_shared))
Add("-out:a.dll"); Add("-out:a.dll");
else else
Add("-out:a.exe"); Add("-out:a.exe");
▲ Show 20 Lines • Show All 108 Lines • Show Last 20 Lines

MinGW/Options.td

Show All 12 Linesdef export_all_symbols: F<"export-all-symbols">,
HelpText<"Export all symbols even if a def file or dllexport attributes are used">; HelpText<"Export all symbols even if a def file or dllexport attributes are used">;
def gc_sections: F<"gc-sections">, HelpText<"Remove unused sections">; def gc_sections: F<"gc-sections">, HelpText<"Remove unused sections">;
def icf: J<"icf=">, HelpText<"Identical code folding">; def icf: J<"icf=">, HelpText<"Identical code folding">;
def image_base: S<"image-base">, HelpText<"Base address of the program">; def image_base: S<"image-base">, HelpText<"Base address of the program">;
def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">; def kill_at: F<"kill-at">, HelpText<"Remove @n from exported symbols">;
def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">, def l: JoinedOrSeparate<["-"], "l">, MetaVarName<"<libName>">,
HelpText<"Root name of library to use">; HelpText<"Root name of library to use">;
def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">; def m: JoinedOrSeparate<["-"], "m">, HelpText<"Set target emulation">;
def map: S<"Map">, HelpText<"Output a linker map">;
def map_eq: J<"Map=">, Alias<map>;
def no_whole_archive: F<"no-whole-archive">, def no_whole_archive: F<"no-whole-archive">,
HelpText<"No longer include all object files for following archives">; HelpText<"No longer include all object files for following archives">;
def large_address_aware: Flag<["--"], "large-address-aware">, def large_address_aware: Flag<["--"], "large-address-aware">,
HelpText<"Enable large addresses">; HelpText<"Enable large addresses">;
def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">; def no_gc_sections: F<"no-gc-sections">, HelpText<"Don't remove unused sections">;
def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">, def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">,
HelpText<"Path to file to write output">; HelpText<"Path to file to write output">;
def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">; def out_implib: Separate<["--"], "out-implib">, HelpText<"Import library name">;
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines

test/MinGW/driver.test

Show First 20 Lines • Show All 128 Lines • ▼ Show 20 Lines
RUN: ld.lld -### -m i386pep foo.o -icf=all | FileCheck -check-prefix ICF %s RUN: ld.lld -### -m i386pep foo.o -icf=all | FileCheck -check-prefix ICF %s
ICF: -opt:icf ICF: -opt:icf
RUN: ld.lld -### -m i386pep --start-group foo.o --end-group RUN: ld.lld -### -m i386pep --start-group foo.o --end-group
RUN: ld.lld -### foo.o -m i386pe -shared --kill-at | FileCheck -check-prefix=KILL-AT %s RUN: ld.lld -### foo.o -m i386pe -shared --kill-at | FileCheck -check-prefix=KILL-AT %s
RUN: ld.lld -### foo.o -m i386pe -shared -kill-at | FileCheck -check-prefix=KILL-AT %s RUN: ld.lld -### foo.o -m i386pe -shared -kill-at | FileCheck -check-prefix=KILL-AT %s
KILL-AT: -kill-at KILL-AT: -kill-at
RUN: ld.lld -### foo.o -m i386pep -Map bar.map | FileCheck -check-prefix=MAP %s
RUN: ld.lld -### foo.o -m i386pep --Map bar.map | FileCheck -check-prefix=MAP %s
RUN: ld.lld -### foo.o -m i386pep -Map=bar.map | FileCheck -check-prefix=MAP %s
RUN: ld.lld -### foo.o -m i386pep --Map=bar.map | FileCheck -check-prefix=MAP %s
MAP: -lldmap:bar.map